ENH: FF/FFO Veto Visualizations

pcdshub / pmps-ui

User interfaces and diagnostics for PMPS

Other

0 stars 8 forks source link

ENH: FF/FFO Veto Visualizations #96

Closed ZLLentz closed 10 months ago

ZLLentz commented 10 months ago

Add filterable veto indicators to the Fast Faults tab
Add veto indicators, veto conditions, and fault counters to the Arbiter Outputs tab.
Remove redundant on-destroy cleanup steps (pydm handles this adequately by default)

There's going to need to be a follow-up for figuring out how to get vetoes onto the Preemptive Requests page. These mostly match their associated FFHWOs but have some exceptions and don't self-report the vetoes.

tangkong commented 10 months ago

UI loads for me as advertised, everything looks nice. I don't immediately see the load time benefits the whole load-row-soon change gives, but maybe loading all those widgets just as fast is the victory here? I'll give the code a more careful read through, but it all looked solid to me at first glance

ZLLentz commented 10 months ago

load time benefits the whole load-row-soon change gives

You'd only notice this if you revert back to one of the commits from before I made the change. I haven't gone back to the other tabs to try to speed them up, so this only makes sure my new additions here don't also increase the load time substantially.

ZLLentz commented 10 months ago

I'm going to go ahead and merge/deploy this to get the new stuff out right away. I'm also going to edit the live pmps ui launcher to use pcds-5.8.0 as that's the version I was testing with.