search

pdebartol / Santorini

Server-Client implementation of the board game "Santorini" by Cranio Creations
1 stars 1 forks source link

explain interface #3

Closed ingconti closed 4 years ago

ingconti commented 4 years ago

at: https://github.com/pierobartolo/ing-sw-2020-debartolomeis-digennaro-dimaio/blob/master/src/main/java/it/polimi/ingsw/network/server/ClientDisconnectionListener.java

are reported 2 methods. pls explaim logic or add javadoc.

marcoDige commented 4 years ago

at: https://github.com/pierobartolo/ing-sw-2020-debartolomeis-digennaro-dimaio/blob/master/src/main/java/it/polimi/ingsw/network/server/EchoServer.java

these 2 methods implementation are commented in javadoc, we have to duplicate the comment also in the interfaces?

ingconti commented 4 years ago

mice point! I suppose the logic in interface, so write javadoc here, and in implementation (real methods) add a brief saying full explanation is in interface (see .... .java) AND eventually pointing out some customised behaviours.