search

peacecorps / Opportunity-Portal

CLOSED - Giving potential applicants a view into the Volunteer opportunities available, along with additional data to make an informed decision to join Peace Corps.
9 stars 6 forks source link

Workflow #23

Closed slgill closed 10 years ago

slgill commented 10 years ago

What is the workflow of getting code changes from github to Google app engine for viewing? There have been changes made to the github repo but are not reflected on the Google app engine.

Mc4llister commented 10 years ago

Assigning to @jkevintu

@slgill Have you been reviewing code as it's submitted? Is that workflow ok?

slgill commented 10 years ago

The changes I was referring to are the @kststudio changes to the index.html file.

kststudio commented 10 years ago

Thanks! I was going to mention it in tonight's meeting. Is there something I need on my end to make the push live on GAE or is someone responsible for reviewing all changes in the repo and then making the push to GAE?

jkevintu commented 10 years ago

Now every change you commit to repository will go live. Code review can be done after you commit the code, then assign your ticket to me.

To speed up our process, It's not necessary to do code review, but I do highly recommend assign the issue to someone you trust and related to it.

For convenience, in your commit message please include the github issue #. See : https://help.github.com/articles/closing-issues-via-commit-messages