image-flash: fix regression with empty partitions

pengutronix / genimage

tool to generate multiple filesystem and flash images from a tree

GNU General Public License v2.0

308 stars 110 forks source link

image-flash: fix regression with empty partitions #103

Closed TobleMiner closed 4 years ago

TobleMiner commented 4 years ago

adf18f077010 ("image-flash: Pad empty flash partitions to size") causes a regression in image-flash.c Due to a difference in handling of the size argument by pad_file depending on infile == NULL adf18f077010 is incorrect. This patch changes the code to call pad_file differently if infile == NULL

Fixes: adf18f077010 ("image-flash: Pad empty flash partitions to size") Signed-off-by: Tobias Schramm t.schramm@manjaro.org

michaelolbrich commented 4 years ago

I think we should change pad_file() instead. Can you test #105?

TobleMiner commented 4 years ago

@michaelolbrich Tested for flash images, seems to work fine. I prefer this approach, too.

michaelolbrich commented 4 years ago

Superseded by #105.