search

pengutronix / genimage

tool to generate multiple filesystem and flash images from a tree
GNU General Public License v2.0
308 stars 110 forks source link

Make sparse clean #121

Closed ukleinek closed 3 years ago

ukleinek commented 4 years ago

This fixes the following warnings when compiling with CC=cgcc:

config.c:197:46: warning: Using plain integer as NULL pointer
image-ext2.c:208:9: warning: Using plain integer as NULL pointer
image-ext2.c:212:9: warning: Using plain integer as NULL pointer
image-ext2.c:213:9: warning: Using plain integer as NULL pointer
image-hd.c:663:11: warning: symbol 'hdimage_opts' was not declared. Should it be static?
image-iso.c:52:9: warning: Using plain integer as NULL pointer
image-rauc.c:191:9: warning: Using plain integer as NULL pointer
image-vfat.c:130:9: warning: Using plain integer as NULL pointer

Note, you might want to also use libconfuse with https://github.com/libconfuse/libconfuse/pull/148, otherwise there are just too many warnings resulting from macros defined there.

If you like this PR it would be great if you label it with hacktoberfest-accepted after application.

ukleinek commented 4 years ago

Checking for DCO is IMHO nonsense as there is no formalism in the code about what a S-o-b means.