search

pengutronix / genimage

tool to generate multiple filesystem and flash images from a tree
GNU General Public License v2.0
308 stars 110 forks source link

image-hd: stricter option handling #138

Closed michaelolbrich closed 3 years ago

michaelolbrich commented 3 years ago

There have been situations where the hybrid mode was accidentally used because a config contained a bogus partition-type entry.

So lets make this explicit: There is now a new 'partition-table-type' option where the hybrid mode must be selected explicitly. The relevant options for mbr and gpt are only acceptable if the corresponding type (or hybrid) is selected.

Signed-off-by: Michael Olbrich m.olbrich@pengutronix.de

michaelolbrich commented 3 years ago

@jameshilliard, there have been some issues with accidentally enabled hybrid mode, so you'll need to explicitly enable it in the future.

jameshilliard commented 3 years ago

there have been some issues with accidentally enabled hybrid mode, so you'll need to explicitly enable it in the future.

Yeah, I did notice there were a number of issues relating to that happening, agree having it as an explicit option makes it less likely to accidentally enable.