pengutronix / genimage

tool to generate multiple filesystem and flash images from a tree
GNU General Public License v2.0
305 stars 110 forks source link

util: systemp(): don't use shell defined in SHELL, but GENIMAGE_SHELL #163

Closed marckleinebudde closed 2 years ago

marckleinebudde commented 3 years ago

As Matthias Schiffer (@schiffermtq) pointed out, using SHELL instead of "/bin/sh" breaks the test suite if not using a POSIX compatible shell like zsh. Fix this problem by not using blindly SHELL, but GENIMAGE_SHELL. If this environment variable is set, we assume the user knows what she's doing.

Link: https://github.com/pengutronix/genimage/pull/161#issuecomment-891761302 Fixes: 1c5301268106 ("util: systemp(): use shell defined in SHELL rather than /bin/sh") Signed-off-by: Marc Kleine-Budde mkl@pengutronix.de