pengutronix / genimage

tool to generate multiple filesystem and flash images from a tree
GNU General Public License v2.0
305 stars 110 forks source link

Initial F2FS support #185

Closed Harvie closed 2 years ago

Harvie commented 2 years ago

Fixes #182

Harvie commented 2 years ago

I am not sure why DCO is failing, because i've added "Signed-off-by..." and it is still red.

jluebbe commented 2 years ago

I am not sure why DCO is failing, because i've added "Signed-off-by..." and it is still red.

See the last paragraph on https://github.com/pengutronix/genimage/pull/185/checks?check_run_id=5627027853: Commit sha: 8dd1329, Author: Tomas Mudrunka, Committer: Tomas Mudrunka; Expected "Tomas Mudrunka tomas@mudrunka.cz", but got "Tomas Mudrunka harviecz@gmail.com".

Harvie commented 2 years ago

F2FS test is now passing when i run ./test/basic-images.test. Let me know when prepare_image(image, image->size); is ready... Or perhaps we can merge this and you uncomment the line yourself once ready to merge that.

michaelolbrich commented 2 years ago

I'm missing changes to Makefile.am to add the new source file.

Harvie commented 2 years ago

I'm missing changes to Makefile.am to add the new source file.

Don't know how it dissappeared again, i swear it was in there alredy :-D It is fixed anyway.

michaelolbrich commented 2 years ago

please add f2fs-tools to the pkgs: in .github/workflows/tests.yml. The package exists for both versions, so please add it to both lists.

Harvie commented 2 years ago

please add f2fs-tools to the pkgs: in .github/workflows/tests.yml. The package exists for both versions, so please add it to both lists.

done

michaelolbrich commented 2 years ago

ERROR: could not open config file 'f2fs.config'

You need to add the file to EXTRA_DIST in Makefile.am

michaelolbrich commented 2 years ago

Run make distcheck locally to check for errors like this.

michaelolbrich commented 2 years ago

An please rebase on master and squash the changes.

Harvie commented 2 years ago

Run make distcheck locally to check for errors like this.

fixed and rebased

Harvie commented 2 years ago

Thank you for review.