Closed Harvie closed 2 years ago
I am not sure why DCO is failing, because i've added "Signed-off-by..." and it is still red.
I am not sure why DCO is failing, because i've added "Signed-off-by..." and it is still red.
See the last paragraph on https://github.com/pengutronix/genimage/pull/185/checks?check_run_id=5627027853: Commit sha: 8dd1329, Author: Tomas Mudrunka, Committer: Tomas Mudrunka; Expected "Tomas Mudrunka tomas@mudrunka.cz", but got "Tomas Mudrunka harviecz@gmail.com".
F2FS test is now passing when i run ./test/basic-images.test
.
Let me know when prepare_image(image, image->size);
is ready... Or perhaps we can merge this and you uncomment the line yourself once ready to merge that.
I'm missing changes to Makefile.am
to add the new source file.
I'm missing changes to Makefile.am to add the new source file.
Don't know how it dissappeared again, i swear it was in there alredy :-D It is fixed anyway.
please add f2fs-tools to the pkgs:
in .github/workflows/tests.yml. The package exists for both versions, so please add it to both lists.
please add f2fs-tools to the
pkgs:
in .github/workflows/tests.yml. The package exists for both versions, so please add it to both lists.
done
ERROR: could not open config file 'f2fs.config'
You need to add the file to EXTRA_DIST
in Makefile.am
Run make distcheck
locally to check for errors like this.
An please rebase on master and squash the changes.
Run
make distcheck
locally to check for errors like this.
fixed and rebased
Thank you for review.
Fixes #182