search

pengutronix / genimage

tool to generate multiple filesystem and flash images from a tree
GNU General Public License v2.0
298 stars 107 forks source link

Add a more GPT partition-type shortcuts #215

Closed rohieb closed 1 year ago

rohieb commented 1 year ago

Barebox State partitions are often used in A/B setups to communicate and control the bootloader's boot decisions. Use the GUID according to the Barebox documentation.

rohieb commented 1 year ago

Now that we have long shortcuts for GPT UUIDs, I've thought about adding the other partition types from the Discoverable Partition Specification (which is also used by systemd-repart). This will add a lot of new shortcuts, but I think it makes sense. But it's also out of scope for this PR, will probably do it in a new one.

rohieb commented 1 year ago

OK it was not really much work at all to add the UUID from the Discoverable Partitions Spec, so these are now included too.

rohieb commented 1 year ago

Hmm. I cannot figure out why the tests keep failing with ERROR: could not open config file 'gpt-type-unknown-shortcut.config'… I'm gonna push some debugging commits.

rohieb commented 1 year ago

Ahh, I have to add the new test configs to EXTRA_DIST. Smart thing, that automake.

rohieb commented 1 year ago

Found uuid_validate and used it instead of the crude strlen(uuid) < 36 check, also improved the tests a bit.

rohieb commented 1 year ago

For the failing tests, see #218