search

pengutronix / genimage

tool to generate multiple filesystem and flash images from a tree
GNU General Public License v2.0
308 stars 110 forks source link

image-ext: Pass 'features' to mke2fs #82

Closed LeSpocky closed 4 years ago

LeSpocky commented 4 years ago

genimage does not pass the config options 'features' to mke2fs when option 'use-mke2fs' is set to true. If the latter option is not set, genext2fs is called instead and tune2fs is run on the image afterwards passing those features.

By not passing that features the behaviour contradicts the documentation and the user expectations.

Fixes: #81 Signed-off-by: Alexander Dahl ada@thorsis.com

LeSpocky commented 4 years ago

If that was non obvious: I force-pushed v2 last week. :smiley:

michaelolbrich commented 4 years ago

I noticed. The code looks good, but I wanted to do some testing myself. I just need to find some time.