search

percival-detector / percivalui

The Percival detector python user interface
0 stars 2 forks source link

Provide script for "Download channel settings" #57

Open ajgdls opened 6 years ago

ajgdls commented 6 years ago

Provide a script corresponding to operation "Download channel settings"

lstebel commented 6 years ago

Awaiting test? What's the name of the script corresponding to operation "Download channel settings"?

ajgdls commented 6 years ago

Hi @lstebel hl_download_channel_settings.py is the file and percival-hl-download-channel-simulator I think is the command line. You will need to run python setup.py install for this to be installed.

lstebel commented 6 years ago

The scripts which you mention cannot be found.

ajgdls commented 6 years ago

I made a typo in the message above sorry. Here is what I have...

(venv27)(dev) [gnx91527@cs03r-sc-serv-21 percivalui]$ percival-hl-download-channel-settings --help usage: percival-hl-download-channel-settings [-h] [-a ADDRESS] [-w WAIT]

Download the channel settings from the ini file to the hardware

optional arguments: -h, --help show this help message and exit -a ADDRESS, --address ADDRESS Odin server address (default 127.0.0.1:8888) -w WAIT, --wait WAIT Wait for the command to complete (default true)

And I see that I hadn't pushed the commits, sorry!!

ajgdls commented 6 years ago

@lstebel Now I have pushed the changes properly I hope that this will be present for you.

lstebel commented 6 years ago

@ajgdls @ulrikpedersen I am trying to edit channel parameters while ODIN server is running.

I observed the following: This percival-hl-download-channel-settings script can be executed after having started the ODIN server. Only the first time it will have an effect: if you run it again, it will have no effect at all. Consequently, at the moment there doen't seem to be any practical way to edit the channel parameters (e.g. monitoring thresholds, safetyaction#_select, etc) while the ODIN server is running. However, this is something important to have.

  1. Can the current behavior be changed?
  2. Can you provide a way to edit channel parameters, similarly to what is currently done for system settings via script percival-hl-set-system_setting?
ajgdls commented 6 years ago

@lstebel we had originally not designed the software to allow re-loading of the channel parameters due to the fundamental nature of these settings (i.e. they describe the available hardware channels).

I think that if some of the settings for channels really need to be changed dynamically we should investigate the ability to change those without having to reload the whole channel parameters ini file. Re-loading this file is almost the same as re-starting the software anyway as it would mean stripping down all of the objects and re-building, so I'm not sure much is gained by allowing it during operations?

lstebel commented 6 years ago

@ajgdls I see your point, but only a subset of settings has such "fundamental"nature: UART_address, Board_type, Channel_name, I2C_address, I2C_Sub_address, I2C_bus_selection,Component_family_ID, Device_ID and Channel_ID. All the others should be made editable in some way. It is maybe a good idea to limit "online" editability to the latter set only.