perdugames / SoftNoise-GDScript-

GDScript function set generating noise (value noise, perlin noise, opensimplex(2d, 3d and 4d)...).
MIT License
108 stars 23 forks source link

Predictabel Noise #4

Open DocTerabyte opened 6 years ago

DocTerabyte commented 6 years ago

Hi, I was very happy to found an open-simplex noise for Godot and Phyton. After Implementation my highmap looks a little bit predictable. The chunks are iterative themself. I looked at the algorythm and found out that the implementation for the permutation is not correct. For correct this you replace the var perm = [] with var perm = [6, 151, 160, 137, 91, 90, 15, 131, 13, 7,201, 95, 96, 53, 194, 233, 7, 225, 8,140, 36, 103, 30, 69, 142, 8, 99, 9,37, 240, 21, 10, 23, 190, 6, 148, 10,247, 120, 234, 75, 0, 26, 197, 62, 11,94, 252, 219, 203, 117, 35, 11, 32, 12,57, 177, 33, 88, 237, 149, 56, 87, 13,174, 20, 125, 136, 171, 168, 68, 175, 14,74, 165, 71, 134, 139, 48, 27, 166, 15,77, 146, 158, 231, 83, 111, 229, 122, 16,60, 211, 133, 230, 220, 105, 92, 41, 17,55, 46, 245, 40, 244, 102, 143, 54, 18,65, 25, 63, 161, 1, 216, 80, 73, 19,209, 76, 132, 187, 208, 89, 18, 169, 20,200, 196, 135, 130, 116, 188, 159, 86, 21,164, 100, 109, 198, 173, 186, 3, 64, 22,52, 217, 226, 250, 124, 123, 5, 202, 23,38, 147, 118, 126, 255, 82, 85, 212, 24,207, 206, 59, 227, 47, 16, 58, 17, 25,182, 189, 28, 42, 223, 183, 170, 213, 26,119, 248, 152, 2, 44, 154, 163, 70, 27,221, 153, 101, 155, 167, 43, 172, 9, 28,129, 22, 39, 253, 19, 98, 108, 110, 29,79, 113, 224, 232, 178, 185, 112, 104, 30,218, 246, 97, 228, 251, 34, 242, 193, 31,238, 210, 144, 12, 191, 179, 162, 241, 32,81, 51, 145, 235, 249, 14, 239, 107, 33,49, 192, 214, 31, 181, 199, 106, 157, 34,184, 84, 204, 176, 115, 121, 50, 45, 35,127, 4, 150, 254, 138, 236, 205, 93, 36,222, 114, 67, 29, 24, 72, 243, 141, 37,128, 195, 78, 66, 215, 61, 156, 180 ]

perdugames commented 6 years ago

the var perm has its values initialized here: https://github.com/PerduGames/SoftNoise-GDScript-/blob/master/softnoise.gd#L144

DocTerabyte commented 6 years ago

Wath i mean is the map will then look like this. Every time it looks like some waves. simplex02

When i change the permutation, the map will look like this: simplex01

perdugames commented 6 years ago

In which function? and I would need to check the algorithm you are generating.

perdugames commented 6 years ago

Check this commit I just gave. https://github.com/PerduGames/SoftNoise-GDScript-/commit/f6b2788ee9515768caf9a5164ede957aefa9ed24 I think the problem has been solved.