pesintta / vdr-plugin-vaapidevice

VDR VAAPIDevice Plug-in
9 stars 12 forks source link

skindesigner not working with latest commit #67

Closed jupe76 closed 6 years ago

jupe76 commented 6 years ago

After updating to the latest set of commits, OSD is not longer shown with skindesigner. VDR-native OSD (i.e. LCARS) is ok.

Digging in the log, this may give a hint. Mar 04 20:07:36 vdrtwo vdr[6575]: [6575] ERROR: cOsd::SetAreas returned 5 (wrong alignment) Mar 04 20:07:36 vdrtwo vdr[6575]: [6575] skindesigner: Error initiating displaychannel view - aborting

pesintta commented 6 years ago

I tried with vdr-2.3.8, skindesigner (latest master) and vaapidevice (latest master) and could not reproduce such behavior.

Have you tried running vaapidevice in fullscreen (-f switch)? It looks like some osd area might be supplied wrong but I don't yet know how to track that. It would be helpful if you could add more debug logging to vdr/skindesigner

More specifically if you could log x, y and width and height in skindesigners cSdOsd::CreateOsd method.

jupe76 commented 6 years ago

I'm also running vdr 2.3.8, latest skindesigner master. Parameters for vaapidevice are -a hw:0,3 -p hw:0,3 -D -f

I'll look after the needed debug informations ...

jupe76 commented 6 years ago

Ok, so with 6372704835b62bee882feed92686edc75e70b55f I'm getting: Mar 04 22:04:37 vdrtwo vdr[14474]: [14474] CreateOsd: x 0, y 0, width 1920, height 1080

With master I'm getting: Mar 04 22:06:48 vdrtwo vdr[14957]: [14957] ERROR: unknown config parameter: vaapidevice.Osd.Height = 0 Mar 04 22:06:48 vdrtwo vdr[14957]: [14957] ERROR: unknown config parameter: vaapidevice.Osd.Width = 0 Mar 04 22:06:49 vdrtwo vdr[14957]: [14957] CreateOsd: x 0, y 0, width 0, height 0 Mar 04 22:06:49 vdrtwo vdr[14957]: [14957] ERROR: cOsd::SetAreas returned 5 (wrong alignment)

Space2Man commented 6 years ago

Hi,

I can confirm the issue ... running latest vaapidevice + latest skindesigner ... using shady-KISS skin ... had to revert because of WAF issue ... I will check for downtime window :)

pesintta commented 6 years ago

I pushed a commit https://github.com/pesintta/vdr-plugin-vaapidevice/commit/48a0f799e12f83abed1b47c4d99def5ed93647d0 to master that might have an effect on this. Can you test that?

jupe76 commented 6 years ago

Hi, thanks, that did the trick. OSD is working again.

Only drawback is that now the log is sometimes flooded with: Mar 04 22:59:12 vdrtwo vdr[18174]: [18174] VAAPI-ERROR: video: VideoGetOsdSize: osd/window size not set yet

Space2Man commented 6 years ago

... moved to new issue since it does not even work without skindesigner for me ... #68

jupe76 commented 6 years ago

closed with 1198cfd43ba311b7349b723bc1ad4ebb675f3227