peter-iakovlev / Telegram

Telegram Messenger for iOS
3.24k stars 859 forks source link

Option to hide the badge count of unread messages in muted chats #31

Open tonysung opened 8 years ago

tonysung commented 8 years ago

This is already done on desktop per https://github.com/overtake/telegram/issues/141 .

Should do the same on iOS.

4tuneTeller commented 8 years ago

+1 I'd sugest and option to completely disable notifications from muted chats (badge numbers are also set by push notifications, if I'm not mistaken), so they won't drain my battery.

etonline commented 8 years ago

Is it the default for muted supergroup? on my device, muted supergroup doesn't count into badge numbers, and I actually want it to be counted... :(

dotKirk commented 8 years ago

+1 Dear god please. I've had to leave so many groups because I can't handle the ever-increasing badge count.

stepan001 commented 8 years ago

+1

audiocommander commented 8 years ago

+1

Doesn't look really complicated: https://github.com/peter-iakovlev/Telegram/blob/58ce610e95aec809a847e928e06c01cffbd317a1/Telegraph/TGAppDelegate.mm#L797

It's already been implemented in the OS X Version: https://github.com/overtake/telegram/issues/141#

SomniusTiger commented 8 years ago

+1 from me as well. I like having the notification bubble on iOS for things that still need my attention. If I've muted a chat, I've decided that unless I'm notified directly (via reply or mention) that I don't need to pay attention to every unread message for that chat. Without this feature, the notification bubble no longer has any importance, and I can't tell if I need to reply to someone or not.

Fenrikur commented 8 years ago

+1 Being able to mute chats without also having them excluded from the unread badge counter makes the badge rather useless indeed, especially since the functionality itself is already available in clients on for other platforms as mentioned above.

last-chance commented 8 years ago

+1

Telegram has quickly replaced text messaging as my way of communicating with friends and family, but now one of the volunteer organizations I help run has decided to use Telegram for communication.

Now my badge counter is permanently in the high hundreds, and I can't really tell when someone is actually trying to get ahold of me. This is getting to a point where I may have to stop using Telegram for anything important.

ha33an commented 8 years ago

i have same problem correct that

r3nya commented 8 years ago

+1

Gryzor commented 8 years ago

+1000 :)

pinver commented 8 years ago

+1

gustavoavena commented 8 years ago

+1

barsukov commented 8 years ago

It is still the issue here :( I mean I still has a problem with it and to be honest I have no idea why it is so complicated to implement so useful bug.

mrsyasi commented 8 years ago

+1

mlabarca commented 8 years ago

Definitely +1

adabu commented 8 years ago

+1

mdevaev commented 8 years ago

+1

maxdrift commented 8 years ago

+1

alexinside commented 8 years ago

+1 It is very annoying. Already thinking to either uninstall the app or disable Badge Icon (iOS). Both solutions are bad.

barsukov commented 8 years ago

I am simply disabled the badge for app. We will see hopefully they will fix it for ios10 update.

iamDecode commented 7 years ago

+1, please, this is currently making Telegram unusable for me..

r3nya commented 7 years ago

@iamDecode and all … Now everything is ok for me. Please check. :)

iamDecode commented 7 years ago

@r3nya What do you mean? Version 3.13 (current App Store version) nor this repo have solved this issue.

audiocommander commented 7 years ago

@r3nya nice that everything is ok for you, I can't see any update or fix or new setting. I basically stopped using telegram for other communications than group chats and disabled the badge setting. So, currently Telegram is one of the most unreliable ways to contact me and the reason is this annoying issue. Telegram would be the best messenger ever if it just got the notifications right. I mean, notifications are one of the most essential aspects of a messenger...

r3nya commented 7 years ago

Ah, damn … Sorry guys. I mean version for iOS. @iamDecode @audiocommander

audiocommander commented 7 years ago

yes, we're talking about the iOS version? as iamDecode said, there's no fix - or do you have different informations?

r3nya commented 7 years ago

@audiocommander yes. I has a lot of muted chats … And my telegram icon without badge. Strange. :)

pochemuto commented 7 years ago

@r3nya so have I. I had received a lot of messages today and badges and notifications appeared only from unmated chats. iOS version 3.13

r3nya commented 7 years ago

Ha! Gotcha! I can't see the badge for muted chats, but I have badge for bots. But I disabled notifications for this bots. 😞

// cc @audiocommander

audiocommander commented 7 years ago

I would rather think that this is another bug. Just made a test. My badge showed 15 unread messages, but I am actually having only 2 unmuted messages and 335 muted messages from various groups. After launching Telegram and not reading any new message, the badge dropped to 14 unread. That definitely doesn't work. (latest iOS, latest Telegram, iPhone 6)

sdugoten commented 7 years ago

Would that be possible that making a switch on badge count for each group? So, one mute switch and one badge switch for each group. So, I could still mute the channel but somehow know someone is talking in a group when badge count shows. BTW, this is IOS version

pdostal commented 7 years ago

It'd be very nice and it's even solved for OSX client.

CareF commented 7 years ago

Also expect this feature

alexdiment commented 7 years ago

I'm surprised this takes forever to fix.

mikexine commented 7 years ago

Looking forward to this :)

ralphbert commented 7 years ago

+1

nezaidu commented 7 years ago

+111111111

emieljanson commented 7 years ago

+1

rivf commented 7 years ago

+1

z3t0 commented 7 years ago

This needs to be implemented on the server side AFAIK which won't happen unless either telegram decides to work on it or releases the source code. Correct me if I am wrong but the source code for the server is not open source?

iamDecode commented 7 years ago

Why? This was already once implemented on the desktop app (before the introduction of the web app) and worked fine. The client just has to determine what unread counts to sum into the final app badge, I don't see how the server is involved in this at all.

Gryzor commented 7 years ago

I agree with @iamDecode

App Badges are locally implemented by Cocoa/UIKit, I don't see how it has anything to do with the server. The app receives messages (among a gazillion other things) via the API, the status of a Chat is locally known by the App, and so the decision to create the Badge should rely on client code given the current API.

I know this is possible because the Mac app was doing it and it was using the Public API.

z3t0 commented 7 years ago

@Gryzor @iamDecode Sorry I was referring to iOS where the badge count is directly connected to the APN push servers. Mac Desktop already has this feature so not sure why that's even a concern.

This is already done on desktop per overtake/telegram#141 . Should do the same on iOS.

As far as I can tell this issue is for iOS

RoOb17 commented 7 years ago

+1 I have a muted supergroup and it's not showing in the badge while the muted group is showing

z3t0 commented 7 years ago

Just FYI.

For more of an explanation as to why this needs to be done on the server side.

The way notifications work on mobile devices when the app is not on the foreground is that push notifications are sent to the servers connected to the phone, in this case Apple's push servers. One of the pieces of information sent is the number of unread notifications.

Currently, on iOS the server sends all the unread count, and does not remove the muted unread count. This is not an issue on Desktop because the server ends it directly to the app which can easily hide any unread messages for the muted converations.

AFAIK telegrams server code is not accessible nor is it open source so unless they fix this I dont really know what there is to be done.

JulyIghor commented 7 years ago

+100

z3t0 commented 7 years ago

This issue should be locked as I have mentioned above that the issue needs to be resolved by telegram and cannot be fixed here.

leo150 commented 7 years ago

Please fix this issue, it's very annoying

Gryzor commented 7 years ago

@leo150 Did you actually read the comments above you before posting? @z3t0 So are you receiving a plain notification with a number and nothing else? Wouldn’t It be possible (albeit lame) to locally track, which ones are muted and subtract from that number? don’t you have to then show the number of unread messages in each group/chat?