search

peterdesmet / petridish

Jekyll theme for research project websites 🧫
https://peterdesmet.github.io/petridish
MIT License
52 stars 44 forks source link

Add favicon #5

Closed peterdesmet closed 2 years ago

peterdesmet commented 5 years ago

Currently getting:

ERROR `/favicon.ico' not found.

When running jekyll serve

jocelynpender commented 2 years ago

Hi Peter! How do you add a favicon when using the petridish template? I couldn't figure it out! It would be great if this were documented. Thanks!

peterdesmet commented 2 years ago

It should work by adding a favicon.ico in the root of the repository (like here https://github.com/inbo/oscibio/blob/main/favicon.ico), but will document this.

jocelynpender commented 2 years ago

That didn't work for my site. I'll keep testing. Thanks for the help!

jocelynpender commented 2 years ago

I hope it's OK that I reused your lovely documentation that I came across 😃 Many thanks!

jocelynpender commented 2 years ago

Did a bunch of digging... still can't figure it out... Please let me know if you find any info on how to set this up, thanks! My site: https://github.com/atlantichabitatmodels/communityofpractice

jocelynpender commented 2 years ago

It should work by adding a favicon.ico in the root of the repository (like here https://github.com/inbo/oscibio/blob/main/favicon.ico), but will document this.

Hello! I've tried many things (e.g., editing config file, creating a head_custom.html file..) but I still haven't been able to get the favicon to show. The file exists in the root of the repository and is named favicon.ico. I think the problem might be to do with the base URL.. Any help resolving this would be much appreciated. I can provide more details on things I've tried if it would be helpful. My experience with jekyll is limited to GitHub pages, so I don't have anything running locally to test. Thanks!

peterdesmet commented 2 years ago

Yes, I think it is indeed related to the baseurl. I'll see if I can resolve it in Petridish.

peterdesmet commented 2 years ago

This should now be resolved in Petridish, but you will have to update your link to the theme to point to the actively developed theme:

remote_theme: peterdesmet/petridish

This isn't good practice though, because you're site might change when I update Petridish. If you can wait, I hope to release a @2.0 soon, which will again be a stable version.

jocelynpender commented 2 years ago

Amazing, thanks so much @peterdesmet ! Let me know when version @2.0 comes out. I don't mind waiting :)

jocelynpender commented 2 years ago

Just a quick note that when I changed to the actively developed theme, the favicon renders, woohoo!! But a bunch of other things are broken, so I'll switch back to the previous release. Let me know when @2.0 comes out, thanks!

E.g., messed up header: image

peterdesmet commented 2 years ago

Version 2.0 is out. @jocelynpender can you link remote_theme: peterdesmet/petridish@2.0 and report back on any issues or things that are resolved?

jocelynpender commented 2 years ago

Hooray! I linked to remote_theme: peterdesmet/petridish@2.0 and everything looks great! Thank you!

peterdesmet commented 2 years ago

Nice! Glad you find it useful.

damianooldoni commented 12 months ago

👋 @peterdesmet! On my browser (Google Chrome) the favicon is not displayed.

Same occurrs on the website I have just started using remote_theme: peterdesmet/petridish@3.0 in _config.yml (see https://github.com/damianooldoni/notes/blob/main/_config.yml#L17).

Do you have any idea why? No urgency at all.

peterdesmet commented 12 months ago

The reason it doesn't appear on https://peterdesmet.com/petridish is because I haven't corrected the setting for https on peterdesmet yet. It does appear on http://peterdesmet.com/petridish or https://peterdesmet.github.io/petridish

A favicon does appear on your https://damianooldoni.github.io/notes/ in my browser.

damianooldoni commented 12 months ago

Thanks @peterdesmet to check this. I find that the favicon on my site is displayed correctly while using Edge instead of a Chrome browser + DuckDuckGo Privay Essentials extension. Also, if I use Chrome with a different account (and no DuckDuckGo extension) the favicon appears correctly. So the extension is the problem.