peterdesmet / petridish

Jekyll theme for research project websites 🧫
https://peterdesmet.github.io/petridish
MIT License
49 stars 44 forks source link

Closing `</div>` is added for tables that do not use `<table>` #78

Closed peterdesmet closed 1 year ago

peterdesmet commented 1 year ago

This line:

https://github.com/peterdesmet/petridish/blob/8b207628086a880271b0d53e5999747079f460f9/_layouts/base.html#L14

Will also add a closing </div> to tables that were not targeted by <table>. As a result, closing </div>s might be injected where they shouldn't.

Possible solution is to target <table rather than <table so all tables are affected the same way. Users won't have a way to disable it then. That's not necessarily bad, but the option should still exist to add extra classes.

peterdesmet commented 1 year ago

This fix should retroactively be applied to version 3.0