search

petobens / trueline

Fast and extensible bash powerline prompt with true color and fancy icon support
MIT License
385 stars 36 forks source link

added support for anaconda (conda) environment #23

Closed Davidportlouis closed 4 years ago

Davidportlouis commented 4 years ago

Added custom color & separate segment for anaconda (conda) environment image added for reference pr_img

petobens commented 4 years ago

Please add an entry to the table in the segments section of the readme and disable this segment by default.

petobens commented 4 years ago

Why is that our conda env variable check is different to https://github.com/chris-marsh/pureline/pull/31/files#diff-9c703c57e323b81e2bea06a75876ecafR266 ? (I don't use conda myself so no idea if one should be preferred over the other one).

Edit: mm actually below that line they use the same env variable as we do so my comment might not be relevant/can-be-ignored

petobens commented 4 years ago

the unaligned marker is shown only in git diff, it renders aligned both in my local machine as well as raw code in my forked repo,

Is that so? So this raw file is wrong? https://raw.githubusercontent.com/petobens/trueline/bfe6ed77aac56637baaad24a21045ef5f16dd141/README.md

Davidportlouis commented 4 years ago

the unaligned marker is shown only in git diff, it renders aligned both in my local machine as well as raw code in my forked repo,

Is that so? So this raw file is wrong? https://raw.githubusercontent.com/petobens/trueline/bfe6ed77aac56637baaad24a21045ef5f16dd141/README.md

sorry didn't see that, now the markers in README have been aligned

petobens commented 4 years ago

Just one last comment. I'll merge after that.

petobens commented 4 years ago

Thank you.

Davidportlouis commented 4 years ago

Thank you.

Thanks for merging, looking forward to contributing more in future