search

petobens / trueline

Fast and extensible bash powerline prompt with true color and fancy icon support
MIT License
385 stars 36 forks source link

Drop the _SSH from TRUELINE_USER_SHOW_IP_SSH #38

Open dgtlife opened 3 years ago

dgtlife commented 3 years ago

The TRUELINE_USER_SHOW_IP_SSH does not appear to be SSH-specific. On my machines, it works like this:

a. When this option is set to "true" on the local machine, the IP address is displayed on the local machine, i.e. IP address in non-SSH mode b. When one SSHs into a remote host that does not have Trueline installed, the prompt is based on whatever is it was set up to be on that machine. c. When one SSHs into a remote machine that has Trueline installed, the prompt that one sees in an SSH session on one's local machine is based on whatever the Trueline configuration is on the remote host. If TRUELINE_USER_SHOW_IP_SSH is set to "false", the hostname is shown in the SSH session on local machine. d. So, as currently implemented TRUELINE_USER_SHOW_IP_SSH affects only the local machine on which it is set, and does not (cannot) affect a remote machine.

So, for clarity the _SSH can be dropped.

petobens commented 3 years ago

Makes sense. Please make a pr

dgtlife commented 3 years ago

Link to the PR https://github.com/petobens/trueline/pull/40#issue-605542997