petrovicstefanrs / 30_seconds_of_knowledge

Google Chrome Extension that lets you gain new developer skills, every time you open a New Tab.
https://30secondsofknowledge.com/
MIT License
942 stars 121 forks source link

Title cut off if too long #145

Open terzom opened 2 months ago

terzom commented 2 months ago

Since it's text-overflow: ellipsis; I guess it's a concise design choice. I don't really agree with that and don't think it looks too bad if it gets on several rows.

If you want to keep it this way, at least give us a way to see the full title, hover on title or something.

Screenshot 2024-04-02 at 14 19 54

petrovicstefanrs commented 2 months ago

@terzom Ah yes, good point, that bugged me too but I felt it wasn't too important for the first version. What would be an ideal way to solve it in your opinion? I like the hover option but it feels like some people might not think of hovering, and I really don't like how it looks when it wraps down, though despite my disliking it, it might be the best way to have it.

By the way. I have a v2.0.1 in development where I'm showing a shortTitle if available, and a full title bellow it, which solves most of the occurrences of this issue. For example this would be the snippet you have in your screenshot

Screenshot 2024-04-06 at 00 38 25
terzom commented 2 months ago

@petrovicstefanrs My first idea was to have some tooltipbox-ish when you hover over but that can look kinda ugly with long text. My next idea was to just expand/Remove the overflow and wrap but making it position absolut to prevent any page jump, think that might be a good solution. Maybe look ugly on smaller screens, solution would be to have smaller font-size for that or just live with it. Have not seen that many with long titles.

Recorded a video to show what I mean:

https://github.com/petrovicstefanrs/30_seconds_of_knowledge/assets/10218269/f6dc79c6-ec2a-4c1f-bf24-ab65e1ec139e

petrovicstefanrs commented 2 months ago

@terzom Got it. The thing is most of the long titles that would have this issue are solved by what i added for the next release with short and long title (screenshot in my previous reply). For the edge cases i will think of a way to display the full title somehow. Anyway, with the next release, this should be solved