search

petrovicstefanrs / 30_seconds_of_knowledge

Google Chrome Extension that lets you gain new developer skills, every time you open a New Tab.
https://30secondsofknowledge.com/
MIT License
942 stars 121 forks source link

Adding blacklist button #40

Closed Kutomore closed 5 years ago

Kutomore commented 5 years ago

Solving #32 image image

petrovicstefanrs commented 5 years ago

@Kutomore Do you plan on adding a page for managing blacklisted snippets like there is one for the saved snippets. I wouldn't like to have users blacklist snippets and not be able to revert it or manage the blacklist?

Kutomore commented 5 years ago

Yep @petrovicstefanrs, I plan on doing in a couple hours.

petrovicstefanrs commented 5 years ago

@Kutomore Cute icon for the blacklisted section 👍 😄 I would maybe keep the saved snippets separated from blacklisted snippets. In their own separate pages? I don't know, do you think it's better to keep them in the same page?

Kutomore commented 5 years ago

Thanks :v, I used one of the sok-Icons as a base. Anyway, I figured they should be in the same page since they serve a similar purpose, they both are used to see what you saved. It only gets different after you are going to use them, since they are saved "differently". Anyway, I just figured that for simplicity sake they should be together, if you want to I can separate them, but IMHO I shouldn't.

petrovicstefanrs commented 5 years ago

@Kutomore , Lets leave it on the same page then, I will however separate them into two separate tabs for the sake of simplicity and I think it'll improve the UX, they are all saved snippets as you said but keeping them in separate tabs will make a necessary distinction between them.

P.S. Sorry for taking so long to merge this, simply not finding the time anymore. I'll try to do it in the next few days! 😄

Kutomore commented 5 years ago

@petrovicstefanrs So, you want me to separate them into two tabs now or you'll do it later? :v Sorry it wasn't clear for me.

petrovicstefanrs commented 5 years ago

@Kutomore Nah man, I'll do it, I want to make it as reusable as possible in case the need arises to use the tabs again. Also really hoping I'll get some time to do the merge soon. There are a lot of changes already by you and other people but I'm just not getting any more breading room. The most free time I can muster is to actually come here and comment on everything.

petrovicstefanrs commented 5 years ago

@Kutomore Just letting you know I'm merging this feature and adding those tabs I mentioned, no issues so far, I hope to release this over the weekend! 😄