search

petrovicstefanrs / 30_seconds_of_knowledge

Google Chrome Extension that lets you gain new developer skills, every time you open a New Tab.
https://30secondsofknowledge.com/
MIT License
942 stars 121 forks source link

Reviewed Three Ruby Snippets #43

Closed meg-gutshall closed 5 years ago

meg-gutshall commented 5 years ago

I saw your open issue #28 and reviewed the first three Ruby snippets. The majority was spelling and grammar issues but I did add some code and documentation to two snippets just to bolster them. No code errors that I could find!

florianjosefreheis commented 5 years ago

Hi @meg-gutshall, thanks for the great work. Snippets look fine, just one small linting change and we are good from my side.

meg-gutshall commented 5 years ago

Yes, @florianjosefreheis that's fine with me! Glad to help!

petrovicstefanrs commented 5 years ago

@meg-gutshall @florianjosefreheis Is this PR ready to be merged? Or do you plan on adding some other changes? If not I'll merge it once you agree.

florianjosefreheis commented 5 years ago

@petrovicstefanrs ok from my side.

meg-gutshall commented 5 years ago

@florianjosefreheis @petrovicstefanrs Ready to merge. I will check other Ruby snippets as I have time and send them through. I'm hoping to do them in chunks of 3-4 at a time and then start creating snippets of my own once all are checked over.

petrovicstefanrs commented 5 years ago

@meg-gutshall @florianjosefreheis , Nice! Merging this and thank you both! 🚀