search

petrovicstefanrs / 30_seconds_of_knowledge

Google Chrome Extension that lets you gain new developer skills, every time you open a New Tab.
https://30secondsofknowledge.com/
MIT License
953 stars 122 forks source link

Feature/saved snippets #6

Closed asantarissy closed 5 years ago

asantarissy commented 5 years ago

This PR is created for a new added feature "Save Snippet", allowing users to save snippets for later.

petrovicstefanrs commented 5 years ago

Hey @asantarissy, Thanks for the feature and your time. I'm sorry that i delay the mere but I'm in the process of writing documentation for contributors and some rules as well.I want to leave this pr until then.

petrovicstefanrs commented 5 years ago

@asantarissy, I've finished reviewing the code. No objections here, other than leaving unused imports in components and a bit of inconsistent naming (Maybe its just me though).

However, could you change this pr to be merged with dev branch instead of master. I want to use git flow, and merging directly into master would be troublesome.

Once I merge your PR into dev, I will probably do some naming changes, change icons to be from the same set as the others and do a bit of styling.

Edit: Also noticed you left some unused vars as well. Eslint should warn you about these if you have it installed. The conf is already in the project.

asantarissy commented 5 years ago

@petrovicstefanrs great, I changed the PR base to dev, and pulled the dev branch to it, let me clean it a little bit and push the edits again.

asantarissy commented 5 years ago

@petrovicstefanrs all is good, I pulled the dev branch and did some cleanups on my files.

Also, if I may, I added eslint and its plugins to devDependencies instead of using the global ones 😃

Cheers!

petrovicstefanrs commented 5 years ago

Also, if I may, I added eslint and its plugins to devDependencies instead of using the global ones 😃

I forgot to add them into devDependencies, didn't I ? Hhaha oooops. Mah bad! :D

petrovicstefanrs commented 5 years ago

@asantarissy Ok, merged, I hope to push my additions over the weekend, and with your save feature push everything to staging by Monday. And possibly release everything finally as version 1.0.0.

I think there is enough features to call it a stable release... ☺️