petrovicstefanrs / 30_seconds_of_knowledge

Google Chrome Extension that lets you gain new developer skills, every time you open a New Tab.
https://30secondsofknowledge.com/
MIT License
953 stars 122 forks source link

Firefox addon doesn't work #85

Closed raulhsj closed 6 months ago

raulhsj commented 4 years ago

This is the url: https://addons.mozilla.org/en-US/firefox/addon/30-seconds-of-knowledge/ It says that the page couldn't be found

petrovicstefanrs commented 4 years ago

Hey @raulhsj, sorry about that. I'm aware it's unavailable at the moment. I had some problems with them reviewing the extension (they couldn't build it). I'm working on that. I hope to have it up again real soon.

mansourmahboubi commented 4 years ago

Hi @petrovicstefanrs Is there a way to install the addon manually for Firefox?

atesztoth commented 4 years ago

Hi @petrovicstefanrs Is there a way to install the addon manually for Firefox?

Hello! Yes, there is! Clone the repository, in a terminal enter the folder, run "npm run build:gecko". Type "about:config" (in Firefox ofc), and search for "xpinstall.signatures.required". Set the boolean value to false, and close this page. After this go to the addons page, and add the extension from file. You'll see a zip file called "gecko_build.zip" in the folder where you cloned the repo to. Add that zip, and you're done!

phoffmeister commented 4 years ago

Hey @petrovicstefanrs any news on getting it back to the official addons page for ff?

mijailr commented 4 years ago

Still getting this error on firefox

mansourmahboubi commented 4 years ago

Hi @petrovicstefanrs Is there a way to install the addon manually for Firefox?

Hello! Yes, there is! Clone the repository, in a terminal enter the folder, run "npm run build:gecko". Type "about:config" (in Firefox ofc), and search for "xpinstall.signatures.required". Set the boolean value to false, and close this page. After this go to the addons page, and add the extension from file. You'll see a zip file called "gecko_build.zip" in the folder where you cloned the repo to. Add that zip, and you're done!

Thanks for the tip I do as you said except firefox after version 48 does not respect xpinstall.signatures.required I switched to firefox developer edition and it's working like a charm. I found some tricks for firefox normal edition but firefox developer edition sounds good to me.

mijailr commented 4 years ago

I was trying to upload a compiled version to get a valid signature. And the failure was related with this part:

https://github.com/petrovicstefanrs/30_seconds_of_knowledge/blob/1107a1b7e3aef01cd7ea7ada6289ca55fedf3e8f/webpack.config.js#L19-L26

After you change the strict_min_version to the latest ESR then the automatic test on the addons page pass the first step.

       gecko: {
        browser_specific_settings: {
            gecko: {
                id: '30secondsofknowledge@petrovicstefan.rs',
-               strict_min_version: '42.0',
+               strict_min_version: '68.0',
            },
        },
    },

But then it complains about the uses of eval and innerHTML functions used by React, so I believe this isn't easy to solve, or anyone know how to use React DOM with safer methods?

Akrabut commented 3 years ago

Hi!

I was wondering if there are any news on making this work from the addons page.

MarcinOrlowski commented 3 years ago

As addition to comment by @atesztoth - simply rename gecko_build.zip to gecko_build.xpi and drag & drop that file on Firefox to install.

Kreeg commented 3 years ago

Firefox still throws an error. I don't want developer edition of Firefox. Any updates?

UPD: Nvm, switched to developer edition

lagerfeuer commented 3 years ago

@petrovicstefanrs any news on the Firefox addon? anything we can help with?

tqaw19 commented 2 years ago

I'd love to get this addon officially on ff. I could open a pull request if needed.

petrovicstefanrs commented 2 years ago

Just recently started working on this project again. I should have a new version soon, and I'll try to fix the FF addon in that update. Sorry for the trouble with it, just couldn't find time to work on this for the past ~2 yrs.

lagerfeuer commented 2 years ago

Sounds great, thanks for the update, and thanks for your time and effort 👍🏼

petrovicstefanrs commented 2 years ago

Small update here. I tried fixing the extension so it worked with FF, but ran into a bunch of other issues. So I decided to do an overhaul. I'll be updating all packages, rewriting react classes to functional components with hooks, and updating manifest to v3. Hopefully, after that is done and the version is stable and easy to develop on, I'll be able to release it as v2 that works on both Chrome and FF. As someone mentioned above, ff complains about using eval and innerHTML, hopefully, this rewrite will address those issues and more. So far I have it set up to work with updated webpack and react and manifest versions, but almost nothing else works because of it, so I'm working on that now.

petrovicstefanrs commented 2 years ago

Another small update. I managed to make the extension work with the new Webpack and new Manifest versions. In the meantime, I also tried reuploading the current (v1.2) version to Firefox for review, in hopes of releasing it again but it's been around 10 days, and no word back from them. The addon portal also has a notification that says they are experiencing high demand and reviews usually take a few weeks.

Anyway, now that the dev version of the extension is working I can start rewriting it to functional components with hooks + make some other improvements and simplify some code.

petrovicstefanrs commented 2 years ago

Another update. The whole extension is now rewritten to react with hooks and manifest v3. I managed to successfully test the extension on Chrome, Brave and Opera browsers.

~Firefox is still having some issues but hopefully, I'll manage to fix it soon or at least come up with a hack to support it until they officially support manifest v3 (I'll probably use v2 for FF until then). For whatever reason documentation around manifest v3 support for FF was not very clear and there was not much of it but 1 thing I've seen was that they projected they would start support for v3 in 2021 Q4. I'm assuming that will be postponed for Q1 2022 so I'll try to have v2 for FF only until then.~

Edit: Managed to make FF work with manifest v2

Edit: Also added some new languages and had to remove support for C++ snippets

deiga commented 2 years ago

Hey @petrovicstefanrs, is there anything that the community can do to support this? We'd love to get this on firefox!

tomal02 commented 1 year ago

I'd be happy to help get this back up onto Firefox, got it running locally for now.