ph1p / ikea-led-obegraensad

ESP32/Arduino hack for the ikea OBEGRÄNSAD led wall lamp
MIT License
596 stars 81 forks source link

fix: Weather and TLS #51

Closed schw4rzlicht closed 10 months ago

schw4rzlicht commented 10 months ago

Hello there,

I noticed some issues with the weather code / TLS. There was an undefined variable that I am fixing in this PR:

https://github.com/schw4rzlicht/ikea-led-obegraensad/blob/670b0e7191ce6a9dbbc8048b12e74ad94ae4145b/src/mode/weather.cpp#L50

Additionally, following was changed to fix an issue with the weather mode (wttr.in is only available via HTTPS now):

The certs will need regular updates, maybe use Github actions for that?

Thanks for your feedback!

[^2]: expired, see https://letsencrypt.org/docs/dst-root-ca-x3-expiration-september-2021/

[^5]: see explanation here