Closed schw4rzlicht closed 10 months ago
Hello there,
I noticed some issues with the weather code / TLS. There was an undefined variable that I am fixing in this PR:
https://github.com/schw4rzlicht/ikea-led-obegraensad/blob/670b0e7191ce6a9dbbc8048b12e74ad94ae4145b/src/mode/weather.cpp#L50
Additionally, following was changed to fix an issue with the weather mode (wttr.in is only available via HTTPS now):
wttr.in
data/cert/cacert-2023-08-22.pem
data/cert/dst_root_ca_x3.pem
DST Root CA X3
data/cert/x509_crt_bundle.bin
gen_crt_bundle.py
include/mode/weather.h
lastUpdate
nextUpdate
platformio.ini
board_build.embed_files
src/mode/weather.cpp
WifiClientSecure
src/webgui.cpp
The certs will need regular updates, maybe use Github actions for that?
Thanks for your feedback!
[^2]: expired, see https://letsencrypt.org/docs/dst-root-ca-x3-expiration-september-2021/
[^5]: see explanation here
Hello there,
I noticed some issues with the weather code / TLS. There was an undefined variable that I am fixing in this PR:
https://github.com/schw4rzlicht/ikea-led-obegraensad/blob/670b0e7191ce6a9dbbc8048b12e74ad94ae4145b/src/mode/weather.cpp#L50
Additionally, following was changed to fix an issue with the weather mode (
wttr.in
is only available via HTTPS now):data/cert/cacert-2023-08-22.pem
: the latest certificate store from Mozilla ^1data/cert/dst_root_ca_x3.pem
: theDST Root CA X3
certificate from LetsEncrypt ^2 which is needed, seedata/cert/x509_crt_bundle.bin
: the bundled certificates ready for upload to the espgen_crt_bundle.py
: bundle script that createsdata/cert/x509_crt_bundle.bin
[^4][^5]include/mode/weather.h
: changedlastUpdate
tonextUpdate
to facilitate quicker retries on failureplatformio.ini
: addedboard_build.embed_files
configuration to upload the cert bundlesrc/mode/weather.cpp
:WifiClientSecure
now to support TLSsrc/webgui.cpp
: not even sure why this was updated...The certs will need regular updates, maybe use Github actions for that?
Thanks for your feedback!
[^2]: expired, see https://letsencrypt.org/docs/dst-root-ca-x3-expiration-september-2021/
[^5]: see explanation here