Closed ahuber21 closed 6 months ago
@ahuber21 Maybe this helps https://github.com/me-no-dev/ESPAsyncWebServer/issues/418#issuecomment-667976368 for the ESP8266 issue
I love it! This is definitely a change that should be merged. The incompatibility issue will come up every time anyway. There are so many different boards. There should just be a description in the README for most boards in case a feature works differently or not at all. A section that says: "If you have this board, then do this and this..." etc.
Hmm, once this is mereged, wound'nt this be the ideal base to add aditionall parameters like timezone?
@ph1p this now builds successfully on both platforms -- on ESP8266 we just keep the old solution.
Unfortunately, the web server started by wifi manager and the one from this package don't like each other. So whenever wifi manager starts a server, we need to reboot the device. This should only happen when no WiFi is found though, so after a successful configuration we should be good.
Maybe there's a cleaner solution I didn't think of. But for now, this runs stably on my display.
I don't fully understand the mDNS
for which I had to fix a few conflicts. I should probably do some more testing if everything still works...
@schw4rzlicht can you take a quick look at my changes--see if anything looks like it would break your mDNS contribution?
@schw4rzlicht can you take a quick look at my changes--see if anything looks like it would break your mDNS contribution?
Looks good to me :)
In this case I'd be ready to merge @ph1p
In this case I'd be ready to merge @ph1p
Alrighty :) Thank you very much for that! I will test it and then it will be merged
I'm not experienced in github and therefore do not know how to review the changes from Andreas Huber. However, I very much like the addition of the WiFi Manager. I made a clone copy of that repository and all works well for me. So, please merge all enhancements back to the original code tree.
This change adds https://github.com/tzapu/WiFiManager. It works without problems on ESP32. On ESP8266 I see compile errors due to conflicting symbols. The HTTP request types are defined multiple times. Looks like
ESPAsyncWebServer.h
andESP8266WebServer.h
are incompatible (error attached below).Before I investigate this further, I wanted to ask if this contribution has a chance of being accepted. If so, I see two options, feel free to comment:
Edit: Please note I had to rename
webserver.{h,cpp} -> asyncwebserver.{h,cpp}
as the wifi manager includesWebServer.h
. The nameasyncwebserver
is of course up for discussion.