ph1p / ikea-led-obegraensad

ESP32/Arduino hack for the ikea OBEGRÄNSAD led wall lamp
MIT License
610 stars 85 forks source link

feat: Pong Clock #77

Closed MoJo2600 closed 11 months ago

MoJo2600 commented 11 months ago

I added a clock that plays pong.

The pong clock was originally written by Jeremy Williams for GameFrameV2 and I ported it to one of my projects and now to this repository.

I have one minor issue, that I was not able to solve atm. There are some flickering pixels sometimes. I can not figure out where they come from. Maybe somebody can test it and have a look at my code?

MoJo2600 commented 11 months ago

Video if it in action

kohlsalem commented 11 months ago

thats a cool one :-)

MoJo2600 commented 11 months ago

Yeah, good point. I can do this. What worries me, are the "ghost" pixels. Not sure why they are happening.

The original drawCharacter function for example does not check if it draws outside the matrix. It seems like the ghost pixels are getting worse when this happens (thus my own implementation). But it still happens.

kohlsalem commented 11 months ago

Yeah, good point. I can do this. What worries me, are the "ghost" pixels. Not sure why they are happening.

The original drawCharacter function for example does not check if it draws outside the matrix. It seems like the ghost pixels are getting worse when this happens (thus my own implementation). But it still happens.

Hmm. i have good and bad news for you.

The good news: I have not a single ghost pixel running your plugin. I manually copyied it 1:1 the plugin, not knowing how to handel it smartly. It just works.

The bad news is, ther there is only a <1% chance that any of my changes on screen.cpp had that effect. I guess it is some hardware issue :-(

ph1p commented 11 months ago

Wow! Nice work :) If you resolve the conflicts it should be ready to merge

MoJo2600 commented 11 months ago

Resolved the conflicts.

Thanks @kohlsalem for testing! I'll check my cables again. Maybe it is really a hardware issue.

ph1p commented 11 months ago

Thank you :) Great work!