search

phhusson / treble_experimentations

Notes about tinkering with Android Project Treble
3.39k stars 655 forks source link

[OnePlus 6 + RR] Rounded display corners not supported properly #114

Open cawilliamson opened 6 years ago

cawilliamson commented 6 years ago

The OP6 has a curved edge display (same as the Pixel 2 XL) and I suspect the same values would work perfectly. From what I found online it looks like the following can enable this:

su
settings put secure sysui_rounded_size 26.0
settings put secure sysui_rounded_content_padding 8.0
su
settings put secure sysui_rounded_size 26.0
settings put secure sysui_rounded_content_padding 8.0

Anyway - these don't persist through a reboot - I was wondering if this is something that can be changed at the overlay level? I'm not sure if this issue is with the GSI or RR itself doing some funky stuff with the statusbar.

I did get these commands to work once and it "solved" the issue - I suspect actually the change may be needed at an RR level so I added both to the ticket title.

axm2 commented 6 years ago

Lineage implements it like this https://github.com/LineageOS/android_device_oneplus_sdm845-common/commit/91ff5c04b44124fa90132ffe10ad004c6c7e87c8

I think we can do the same by doing the same in https://github.com/phhusson/vendor_hardware_overlay/tree/master/OnePlus/OP6/res/values

edit: I made a pull request https://github.com/phhusson/vendor_hardware_overlay/pull/8

phhusson commented 5 years ago

That's not ideal, but at least there is an option for the users, with https://github.com/phhusson/treble_app/commit/35c566dff568702d30fdc7dc5b1a7c7bd93331e8