phhusson / treble_experimentations

Notes about tinkering with Android Project Treble
3.37k stars 657 forks source link

Brightness bar doesn't work on HTC U12+ #368

Open jeanrivera opened 5 years ago

jeanrivera commented 5 years ago

not sure if this helps to fix the brightness bar please ask me what I can provide to fix it

getprop.txt

ghost commented 5 years ago

What does not work? Is the function greyed out or does the slider nothing?

jeanrivera commented 5 years ago

The slider does nothing

ghost commented 5 years ago

Another overlay may be needed.

@phhusson

phhusson commented 5 years ago

an it's own won't fix the slider

Le lun. 21 janv. 2019 à 13:46, xBrownieCodez notifications@github.com a écrit :

Another overlay may be needed.

@phhusson https://github.com/phhusson

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/phhusson/treble_experimentations/issues/368#issuecomment-456062335, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAOOmggYZ2GUTz_uhN79NbEHYQ-aic5ks5vFbajgaJpZM4aJojU .

jeanrivera commented 5 years ago

treble-overlay-htc-u12plus.apk.zip a friend build this for me but apparently still not working

jeanrivera commented 5 years ago

logcat.txt

phhusson commented 5 years ago

An overlay won't fix brightness bar.

jeanrivera commented 5 years ago

Could guide me in the right direction,please, maybe I could provide from stock what is needed to fix the issue, or if another log or something else need to be done to fix it thanks in advance

phhusson commented 5 years ago

could you try instructions at https://github.com/phhusson/treble_experimentations/issues/414#issuecomment-470710064 ?

jeanrivera commented 5 years ago

I can do it on Monday, I'll report back

jeanrivera commented 5 years ago

I only noticed a difference after the second command "C:\ADB>adb shell lightsctl BACKLIGHT 80" the screen dimmed and it bumped back to original level on third command "C:\ADB>adb shell lightsctl BACKLIGHT ff808080"

other than that I did not noticed any other changes

forgot to mention that the brightness level never actually changed on the settings it was always displaying 78%

C:\ADB>adb root

C:\ADB>adb shell lightsctl BACKLIGHT ff
Got type BACKLIGHT
Got type BATTERY
Got type NOTIFICATIONS
Got type ATTENTION
Set request type BACKLIGHT
Set flash type to NONE
Set light returned SUCCESS

C:\ADB>adb shell lightsctl BACKLIGHT 80
Got type BACKLIGHT
Got type BATTERY
Got type NOTIFICATIONS
Got type ATTENTION
Set request type BACKLIGHT
Set flash type to NONE
Set light returned SUCCESS

C:\ADB>adb shell lightsctl BACKLIGHT ff808080
Got type BACKLIGHT
Got type BATTERY
Got type NOTIFICATIONS
Got type ATTENTION
Set request type BACKLIGHT
Set flash type to NONE
Set light returned SUCCESS

C:\ADB>adb shell lightsctl BACKLIGHT 80808080
Got type BACKLIGHT
Got type BATTERY
Got type NOTIFICATIONS
Got type ATTENTION
Set request type BACKLIGHT
Set flash type to NONE
Set light returned SUCCESS

C:\ADB>adb shell lightsctl BACKLIGHT 3ff
Got type BACKLIGHT
Got type BATTERY
Got type NOTIFICATIONS
Got type ATTENTION
Set request type BACKLIGHT
Set flash type to NONE
Set light returned SUCCESS

C:\ADB>adb shell lightsctl BACKLIGHT 1fff
Got type BACKLIGHT
Got type BATTERY
Got type NOTIFICATIONS
Got type ATTENTION
Set request type BACKLIGHT
Set flash type to NONE
Set light returned SUCCESS

C:\ADB>adb shell lightsctl BACKLIGHT ff HARDWARE 0 0
Got type BACKLIGHT
Got type BATTERY
Got type NOTIFICATIONS
Got type ATTENTION
Set request type BACKLIGHT
Set flash type to HARDWARE
Set light returned SUCCESS

C:\ADB>adb shell lightsctl BACKLIGHT 3ff HARDWARE 0 0
Got type BACKLIGHT
Got type BATTERY
Got type NOTIFICATIONS
Got type ATTENTION
Set request type BACKLIGHT
Set flash type to HARDWARE
Set light returned SUCCESS

C:\ADB>adb shell lightsctl BACKLIGHT 1fff HARDWARE 0 0
Got type BACKLIGHT
Got type BATTERY
Got type NOTIFICATIONS
Got type ATTENTION
Set request type BACKLIGHT
Set flash type to HARDWARE
Set light returned SUCCESS
phhusson commented 5 years ago

lightsctl BACKLIGHT 15 ?

Le mar. 12 mars 2019 à 09:02, jeanrivera notifications@github.com a écrit :

I only noticed a difference after the second command "C:\ADB>adb shell lightsctl BACKLIGHT 80" the screen dimmed and it bumped back to original level on third command "C:\ADB>adb shell lightsctl BACKLIGHT ff808080"

other than that I did not noticed any other changes

C:\ADB>adb root

C:\ADB>adb shell lightsctl BACKLIGHT ff Got type BACKLIGHT Got type BATTERY Got type NOTIFICATIONS Got type ATTENTION Set request type BACKLIGHT Set flash type to NONE Set light returned SUCCESS

C:\ADB>adb shell lightsctl BACKLIGHT 80 Got type BACKLIGHT Got type BATTERY Got type NOTIFICATIONS Got type ATTENTION Set request type BACKLIGHT Set flash type to NONE Set light returned SUCCESS

C:\ADB>adb shell lightsctl BACKLIGHT ff808080 Got type BACKLIGHT Got type BATTERY Got type NOTIFICATIONS Got type ATTENTION Set request type BACKLIGHT Set flash type to NONE Set light returned SUCCESS

C:\ADB>adb shell lightsctl BACKLIGHT 80808080 Got type BACKLIGHT Got type BATTERY Got type NOTIFICATIONS Got type ATTENTION Set request type BACKLIGHT Set flash type to NONE Set light returned SUCCESS

C:\ADB>adb shell lightsctl BACKLIGHT 3ff Got type BACKLIGHT Got type BATTERY Got type NOTIFICATIONS Got type ATTENTION Set request type BACKLIGHT Set flash type to NONE Set light returned SUCCESS

C:\ADB>adb shell lightsctl BACKLIGHT 1fff Got type BACKLIGHT Got type BATTERY Got type NOTIFICATIONS Got type ATTENTION Set request type BACKLIGHT Set flash type to NONE Set light returned SUCCESS

C:\ADB>adb shell lightsctl BACKLIGHT ff HARDWARE 0 0 Got type BACKLIGHT Got type BATTERY Got type NOTIFICATIONS Got type ATTENTION Set request type BACKLIGHT Set flash type to HARDWARE Set light returned SUCCESS

C:\ADB>adb shell lightsctl BACKLIGHT 3ff HARDWARE 0 0 Got type BACKLIGHT Got type BATTERY Got type NOTIFICATIONS Got type ATTENTION Set request type BACKLIGHT Set flash type to HARDWARE Set light returned SUCCESS

C:\ADB>adb shell lightsctl BACKLIGHT 1fff HARDWARE 0 0 Got type BACKLIGHT Got type BATTERY Got type NOTIFICATIONS Got type ATTENTION Set request type BACKLIGHT Set flash type to HARDWARE Set light returned SUCCESS

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/phhusson/treble_experimentations/issues/368#issuecomment-471895726, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAOOni1NKcsYusdELJrOnPdGWq9Curuks5vV18jgaJpZM4aJojU .

jeanrivera commented 5 years ago

this one turned the screen very dark

C:\ADB>adb shell lightsctl BACKLIGHT 15
Got type BACKLIGHT
Got type BATTERY
Got type NOTIFICATIONS
Got type ATTENTION
Set request type BACKLIGHT
Set flash type to NONE
Set light returned SUCCESS
phhusson commented 5 years ago

Try setprop persist.sys.qcom-brightness 255 And reboot

Le mar. 12 mars 2019 à 09:02, jeanrivera notifications@github.com a écrit :

I only noticed a difference after the second command "C:\ADB>adb shell lightsctl BACKLIGHT 80" the screen dimmed and it bumped back to original level on third command "C:\ADB>adb shell lightsctl BACKLIGHT ff808080"

other than that I did not noticed any other changes

C:\ADB>adb root

C:\ADB>adb shell lightsctl BACKLIGHT ff Got type BACKLIGHT Got type BATTERY Got type NOTIFICATIONS Got type ATTENTION Set request type BACKLIGHT Set flash type to NONE Set light returned SUCCESS

C:\ADB>adb shell lightsctl BACKLIGHT 80 Got type BACKLIGHT Got type BATTERY Got type NOTIFICATIONS Got type ATTENTION Set request type BACKLIGHT Set flash type to NONE Set light returned SUCCESS

C:\ADB>adb shell lightsctl BACKLIGHT ff808080 Got type BACKLIGHT Got type BATTERY Got type NOTIFICATIONS Got type ATTENTION Set request type BACKLIGHT Set flash type to NONE Set light returned SUCCESS

C:\ADB>adb shell lightsctl BACKLIGHT 80808080 Got type BACKLIGHT Got type BATTERY Got type NOTIFICATIONS Got type ATTENTION Set request type BACKLIGHT Set flash type to NONE Set light returned SUCCESS

C:\ADB>adb shell lightsctl BACKLIGHT 3ff Got type BACKLIGHT Got type BATTERY Got type NOTIFICATIONS Got type ATTENTION Set request type BACKLIGHT Set flash type to NONE Set light returned SUCCESS

C:\ADB>adb shell lightsctl BACKLIGHT 1fff Got type BACKLIGHT Got type BATTERY Got type NOTIFICATIONS Got type ATTENTION Set request type BACKLIGHT Set flash type to NONE Set light returned SUCCESS

C:\ADB>adb shell lightsctl BACKLIGHT ff HARDWARE 0 0 Got type BACKLIGHT Got type BATTERY Got type NOTIFICATIONS Got type ATTENTION Set request type BACKLIGHT Set flash type to HARDWARE Set light returned SUCCESS

C:\ADB>adb shell lightsctl BACKLIGHT 3ff HARDWARE 0 0 Got type BACKLIGHT Got type BATTERY Got type NOTIFICATIONS Got type ATTENTION Set request type BACKLIGHT Set flash type to HARDWARE Set light returned SUCCESS

C:\ADB>adb shell lightsctl BACKLIGHT 1fff HARDWARE 0 0 Got type BACKLIGHT Got type BATTERY Got type NOTIFICATIONS Got type ATTENTION Set request type BACKLIGHT Set flash type to HARDWARE Set light returned SUCCESS

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/phhusson/treble_experimentations/issues/368#issuecomment-471895726, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAOOni1NKcsYusdELJrOnPdGWq9Curuks5vV18jgaJpZM4aJojU .

jeanrivera commented 5 years ago

wow you are genius that make it work!!!!!!!!!! thanks so much Master!!!

jeanrivera commented 5 years ago

should I do that command on every new release? or would it be integrated? from now on?

phhusson commented 5 years ago

It's in /data, so persistent across updates, though not factory resets. But yeah I'll integrate it. Can you paste the result of getprop ?

Le mar. 12 mars 2019 à 09:13, jeanrivera notifications@github.com a écrit :

should I do that command on every new release? or would it be integrated? from now on?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/phhusson/treble_experimentations/issues/368#issuecomment-471898639, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAOOmmkaPlnX8juQkV_1Uxivth_hR4oks5vV2HBgaJpZM4aJojU .

jeanrivera commented 5 years ago

I have converted my device to HTC Exodus1 I know the current overlay won't work since it is meant for U12+ and it is not working for me probably because of that, I'll try to build one for Exodus1 and report back `C:\ADB>adb shell phhgsi_arm64_ab:/ $ getprop

[gsm.version.ril-impl]: [Qualcomm RIL 1.0]

[ro.bootimage.build.date]: [Tue Mar 5 15:27:14 UTC 2019]

[ro.build.date]: [Tue Mar 5 15:27:14 UTC 2019]

[ro.build.description]: [treble_arm64_bgS-userdebug 9 PQ2A.190305.002 190305 test-keys] [ro.build.display.id]: [treble_arm64_bgS-userdebug 9 PQ2A.190305.002 190305 test-keys]

[ro.keymaster.mod]: [AOSP on ARM64]

[ro.product.model]: [Phh-Treble with GApps]

[ro.vendor.build.date]: [一 2月 18 22:23:37 CST 2019]

phhgsi_arm64_ab:/ $`

jeanrivera commented 5 years ago

getprop.txt

rfgamaral commented 5 years ago

Try setprop persist.sys.qcom-brightness 255 And reboot

This solved the brightness slider issue on the HTC U12+. After rebooting, the device starts with max brightness as usual but the brightness slider now works just fine. Is it possible to incorporate this change by on the GSI base ROM for the HTC U12+? If possible, with a lower more sensible default value :)