phhusson / treble_experimentations

Notes about tinkering with Android Project Treble
3.32k stars 655 forks source link

BTM_BYPASS_EXTRA_ACL_SETUP issue at device/phh/treble/bluetooth/bdroid_buildcfg.h #658

Open lisandrocarmona opened 4 years ago

lisandrocarmona commented 4 years ago

Some ROMs (at least, crdroid and Evolution X) are failing to compile due to the following error:

system/bt/stack/btm/btm_acl.cc:1187:6: error: function-like macro 'BtmBypassExtraAclSetup' is not defined

if (BTM_BYPASS_EXTRA_ACL_SETUP == FALSE)

device/phh/treble/bluetooth/bdroid_buildcfg.h:52:36: note: expanded from macro 'BTM_BYPASS_EXTRA_ACL_SETUP'

define BTM_BYPASS_EXTRA_ACL_SETUP BtmBypassExtraAclSetup()

Full log:

`[ 69% 62110/89883] //system/bt/stack:libbt-stack clang++ btm/btm_acl.cc FAILED: /media/technical/Extended/evox/out/soong/.intermediates/system/bt/stack/libbt-stack/android_arm64_armv8-a_core_static_cfi/obj/system/bt/stack/btm/btm_acl.o PWD=/proc/self/cwd prebuilts/clang/host/linux-x86/clang-4691093/bin/clang++ -c -Isystem/bt/stack/include -Isystem/bt/stack/avct -Isystem/bt/stack/btm -Isystem/bt/stack/avrc -Isystem/bt/stack/l2cap -Isystem/bt/stack/avdt -Isystem/bt/stack/gatt -Isystem/bt/stack/gap -Isystem/bt/stack/pan -Isystem/bt/stack/bnep -Isystem/bt/stack/hid -Isystem/bt/stack/sdp -Isystem/bt/stack/smp -Isystem/bt/stack/srvc -Idevice/phh/treble/bluetooth -Idevice/phh/treble/bluetooth -Idevice/phh/treble/bluetooth -Iexternal/aac/libAACenc/include -Iexternal/aac/libAACdec/include -Iexternal/aac/libSYS/include -Iexternal/libldac/inc -Iexternal/libldac/abr/inc -Isystem/bt -Isystem/bt/btcore/include -Isystem/bt/vnd/include -Isystem/bt/vnd/ble -Isystem/bt/btif/include -Isystem/bt/hci/include -Isystem/bt/internal_include -Isystem/bt/udrv/include -Isystem/bt/bta/include -Isystem/bt/bta/sys -Isystem/bt/utils/include -Isystem/bt/stack -Werror=implicit-function-declaration -DANDROID -fmessage-length=0 -W -Wall -Wno-unused -Winit-self -Wpointer-arith -no-canonical-prefixes -DNDEBUG -UDEBUG -fno-exceptions -Wno-multichar -O2 -g -fno-strict-aliasing -fdebug-prefix-map=/proc/self/cwd= -D__compiler_offsetof=builtin_offsetof -Werror=int-conversion -Wno-reserved-id-macro -Wno-format-pedantic -Wno-unused-command-line-argument -fcolor-diagnostics -Wno-expansion-to-defined -Wno-zero-as-null-pointer-constant -fdebug-prefix-map=$PWD/= -ffunction-sections -fdata-sections -fno-short-enums -funwind-tables -fstack-protector-strong -Wa,--noexecstack -D_FORTIFY_SOURCE=2 -Wstrict-aliasing=2 -Werror=return-type -Werror=non-virtual-dtor -Werror=address -Werror=sequence-point -Werror=date-time -Werror=format-security -nostdlibinc -march=armv8-a -Isystem/bt/include -Isystem/bt/include/hardware/avrcp -Isystem/bt/internal_include -Iexternal/googletest/googletest/include -Isystem/core/base/include -I/media/technical/Extended/evox/out/soong/.intermediates/external/libchrome/libchrome-include/gen/external/libchrome -Isystem/bt/types -Iexternal/aac/libAACdec/include -Iexternal/aac/libAACenc/include -Iexternal/aac/libPCMutils/include -Iexternal/aac/libFDK/include -Iexternal/aac/libSYS/include -Iexternal/aac/libMpegTPDec/include -Iexternal/aac/libMpegTPEnc/include -Iexternal/aac/libSBRdec/include -Iexternal/aac/libSBRenc/include -Iexternal/aac/libArithCoding/include -Iexternal/aac/libDRCdec/include -Iexternal/aac/libSACdec/include -Iexternal/aac/libSACenc/include -Iexternal/libcxx/include -Iexternal/libcxxabi/include -Isystem/core/libcutils/include -Isystem/core/liblog/include -I/media/technical/Extended/evox/out/soong/.intermediates/frameworks/base/tools/stats_log_api_gen/statslog.h/gen -Isystem/core/include -Isystem/media/audio/include -Ihardware/libhardware/include -Ihardware/libhardware_legacy/include -Ihardware/ril/include -Ilibnativehelper/include -Iframeworks/native/include -Iframeworks/native/opengl/include -Iframeworks/av/include -isystem bionic/libc/include -isystem bionic/libc/kernel/uapi -isystem bionic/libc/kernel/uapi/asm-arm64 -isystem bionic/libc/kernel/android/scsi -isystem bionic/libc/kernel/android/uapi -Ilibnativehelper/include_jni -Wall -Wextra -Werror -DHAS_BDROID_BUILDCFG '-DEXPORT_SYMBOL=attribute__((visibility("default")))' -fvisibility=hidden -Wno-gnu-variable-sized-type-not-at-end -Wno-unused-parameter -DLOG_NDEBUG=1 -DHAS_BDROID_BUILDCFG -DHAS_BDROID_BUILDCFG -DBLUEDROID_DEBUG -target aarch64-linux-android -Bprebuilts/gcc/linux-x86/aarch64/aarch64-linux-android-4.9/aarch64-linux-android/bin -DANDROID_STRICT -fPIC -D_USING_LIBCXX -flto -fsanitize-cfi-cross-dso -fsanitize-blacklist=external/compiler-rt/lib/cfi/cfi_blacklist.txt -fsanitize=cfi -fsanitize-trap=all -ftrap-function=abort -fno-sanitize-trap=cfi -std=gnu++14 -Wsign-promo -Wno-inconsistent-missing-override -Wno-null-dereference -D_LIBCPP_ENABLE_THREAD_SAFETY_ANNOTATIONS -Wno-thread-safety-negative -Wno-gnu-include-next -fvisibility-inlines-hidden -fno-rtti -Werror=int-to-pointer-cast -Werror=pointer-to-int-cast -Werror=address-of-temporary -Werror=return-type -Wno-tautological-constant-compare -Wno-null-pointer-arithmetic -Wno-enum-compare -Wno-enum-compare-switch -MD -MF /media/technical/Extended/evox/out/soong/.intermediates/system/bt/stack/libbt-stack/android_arm64_armv8-a_core_static_cfi/obj/system/bt/stack/btm/btm_acl.o.d -o /media/technical/Extended/evox/out/soong/.intermediates/system/bt/stack/libbt-stack/android_arm64_armv8-a_core_static_cfi/obj/system/bt/stack/btm/btm_acl.o system/bt/stack/btm/btm_acl.cc system/bt/stack/btm/btm_acl.cc:1187:6: error: function-like macro 'BtmBypassExtraAclSetup' is not defined

if (BTM_BYPASS_EXTRA_ACL_SETUP == FALSE)

 ^

device/phh/treble/bluetooth/bdroid_buildcfg.h:52:36: note: expanded from macro 'BTM_BYPASS_EXTRA_ACL_SETUP'

define BTM_BYPASS_EXTRA_ACL_SETUP BtmBypassExtraAclSetup()

                               ^

1 error generated. [ 69% 62113/89883] //system/bt/stack:libbt-stack clang++ btm/btm_ble_adv_filter.cc ninja: build stopped: subcommand failed. 18:25:44 ninja failed with: exit status 1 `

Iceows commented 2 years ago

I just had the problem just compiling an aosp from phh.

hhyygg2009 commented 8 months ago

SOLVED: USE #define BTM_BYPASS_EXTRA_ACL_SETUP TRUE INSTEAD