search

philschatz / atom-pull-requests

:octocat: View/Edit comments on a Pull Request directly inside the Atom Editor
47 stars 9 forks source link

Uncaught TypeError: this._fetchComments(...).catch is not a function #1

Closed qingfeng closed 8 years ago

qingfeng commented 8 years ago

[Enter steps to reproduce below:]

  1. ...
  2. ...

Atom Version: 1.2.1 System: Mac OS X 10.10.5 Thrown From: pull-requests package, v0.0.6

Stack Trace

Uncaught TypeError: this._fetchComments(...).catch is not a function

At /Users/qingfeng/Dropbox/atom_config/packages/pull-requests/lib/gh-client.coffee:59

TypeError: this._fetchComments(...).catch is not a function
    at GitHubClient.module.exports.GitHubClient.getCommentsPromise (/Users/qingfeng/Dropbox/atom_config/packages/pull-requests/lib/gh-client.coffee:58:29)
    at TreeViewDecorator.module.exports.TreeViewDecorator.poll (/Users/qingfeng/Dropbox/atom_config/packages/pull-requests/lib/tree-view-decorator.coffee:32:14)

Commands

     -8:38.4.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -8:17 core:select-all (atom-text-editor.editor.mini.is-focused)
     -8:15.6.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -8:05.2.0 core:select-all (atom-text-editor.editor.mini.is-focused)
     -8:05.0 core:paste (atom-text-editor.editor.mini.is-focused)
     -8:04.8.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -7:12 core:select-all (atom-text-editor.editor.mini.is-focused)
     -7:00.9.0 core:close (atom-text-editor.editor.mini.is-focused)
     -2:45.3.0 settings-view:open (atom-text-editor.editor.is-focused)
     -2:43.3.0 core:select-all (atom-text-editor.editor.mini.is-focused)
     -2:41.5.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -2:14.6.0 core:close (div.package-detail.panels-item)
     -0:41.2.0 settings-view:open (atom-text-editor.editor.is-focused)
     -0:38.6.0 core:select-all (atom-text-editor.editor.mini.is-focused)
     -0:38.3.0 core:paste (atom-text-editor.editor.mini.is-focused)
     -0:38.2.0 core:confirm (atom-text-editor.editor.mini.is-focused)

Config

{
  "core": {
    "ignoredNames": [
      ".git",
      ".svn",
      ".DS_Store"
    ],
    "themes": [
      "atom-dark-ui",
      "batman-syntax"
    ],
    "disabledPackages": [
      "pep8",
      "task-list"
    ]
  },
  "pull-requests": {
    "githubAuthorizationToken": "e0e9b738c9a79038002e944afc51b1106c1195e6"
  }
}

Installed Packages

# User
achievements, v0.9.0
batman-syntax, v1.0.1
bottom-dock, v0.3.5
clock, v1.4.0
counter, v0.3.3
django-templates, v0.5.0
editor-stats, v0.17.0
editorconfig, v1.2.2
file-icons, v1.6.11
gist-it, v0.8.0
language-asciidoc, v0.12.0
language-django, v0.1.1
linter, v1.11.2
linter-flake8, v1.9.2
linter-jscs, v3.2.0
local-history, v3.2.3
news-line, v0.2.0
nyancat, v0.2.0
pigments, v0.18.1
pull-requests, v0.0.6
react, v0.12.10
todo-manager, v0.2.6
travis-ci-status, v0.18.0
wakatime, v5.0.0
zentabs, v0.8.6

# Dev
No dev packages
philschatz commented 8 years ago

Thanks, I was using a dev build of atom! It should work now with 0.0.8 :smile: