search

philschatz / atom-pull-requests

:octocat: View/Edit comments on a Pull Request directly inside the Atom Editor
47 stars 9 forks source link

What kind-of icons do you want linter to show in gutter? #19

Closed steelbrain closed 8 years ago

steelbrain commented 8 years ago

You mentioned it in the README, can you provide a screenshot or something explaining the idea

philschatz commented 8 years ago

Thanks for taking a look into this! I was hoping to be able to use octicons in the gutter and in the linter messages.

I was able to add the comment icon (see the following screenshot) by overriding the info circle that normally shows up in the gutter. Unfortunately, it's an ugly CSS hack and comes with problems:

  1. if any other linter runs on the page and uses the info, their icon will also be a comment icon
  2. to get the icon to show up I had to mangle the CSS which generates a circle by default (see source
  3. If a user uses a custom theme this hack causes problems (I don't remember exactly how/when but someone reported it about a year ago)

I hope that helps, and if I can test a branch, I'd be happy to!

steelbrain commented 8 years ago

Sounds fair enough, would you like to open an issue in the linter repo as well as the ui repo so we can implement this?

steelbrain commented 8 years ago

Update:

I've opened https://github.com/steelbrain/linter/issues/1224 and https://github.com/steelbrain/linter-ui-default/issues/121