search

philschatz / atom-pull-requests

:octocat: View/Edit comments on a Pull Request directly inside the Atom Editor
47 stars 9 forks source link

Keep OAuth key out of config.cson #20

Closed bastilian closed 7 years ago

bastilian commented 7 years ago

I just noticed that the OAuth key is saved to atoms config.scon, since a number of people are syncing their editor configurations, sometimes even publicly it, presents a hurdle to make sure this key is not pushed to the public.

A suggestion would be to use keytar (https://github.com/atom/node-keytar) to store the credentials safely.

philschatz commented 7 years ago

Thanks for bringing this up! I finally got some free time over the holidays to work on this 😄 .

A fix will be in the next version but I still need to clean up #25 a bit. Feel free to comment on the PR!