Switching tabs removes decorations

phindle / error-lens

Visual Studio Code extension which enhances the display of errors and warnings.

https://marketplace.visualstudio.com/items?itemName=PhilHindle.errorlens

MIT License

89 stars 40 forks source link

Switching tabs removes decorations #8

Closed usernamehw closed 5 years ago

usernamehw commented 5 years ago

Issue Type: Bug

removes_decorations

Decorations return after modifying the document. But is it possible to keep them even after switching?

Extension version: 1.0.0 VS Code version: Code 1.28.2 (7f3ce96ff4729c91352ae6def877e59c561f4850, 2018-10-17T00:23:51.859Z) OS version: Windows_NT x64 10.0.17134

pushqrdx commented 5 years ago

yeah happens here too, makes the extension useless i hope it gets fixed

usernamehw commented 5 years ago

@phindle c'mon it's a 4-line fix:

vscode.window.onDidChangeActiveTextEditor(textEditor => {
    if (textEditor === undefined) return;
    updateDecorationsForUri(textEditor.document.uri, textEditor);
}, null, context.subscriptions);

phindle commented 5 years ago

Hi folks - apologies for not getting on to this, I've been busy moving house so I've not been able to look at these issues. As soon as my development PC is back up & running I can sort this out. Thank you for your patience.

phindle commented 5 years ago

Back onto this project at last. Looking at this now.

phindle commented 5 years ago

Now published to Extension Marketplace as v1.1.0.