search

phloxic / videojs-sprite-thumbnails

Video.js plugin to display thumbnails from a sprite image when hovering over the progress bar
https://lastshiphome.de/en/movie
MIT License
52 stars 13 forks source link

time tooltip out of bounds on the right of player #49

Closed phloxic closed 1 month ago

phloxic commented 1 year ago

Since Video.js version 7.9.4 the time tooltips can go out of bounds on the right side of the player.

See e.g. https://github.com/videojs/video.js/issues/7248 and not accepted fix https://github.com/videojs/video.js/pull/7308 et.al.

This affects the plugin because it hijacks the tooltip in the mouse time display to display the preview thumbnails. Especially with widescreen movies and/or few/none buttons/menus to the right of the progressbar, the thumbnail might go (partially) out of bounds on the right side.

A nasty emergency fix would be to set overflow: hidden on the player container.

phloxic commented 1 year ago

See: See https://github.com/videojs/video.js/issues/8273

phloxic commented 1 year ago

imho, for the time being applying this small change to a recent version of Video.js (either v7.x or v8.x) solves the problem without the side-effects which were the reason the patch was declined at the time.

phloxic commented 1 month ago

Since https://github.com/videojs/video.js/commit/50f14bd66d422a0a23637fc30b2c72e616596076 the time tooltip does not out of bounds of the control bar by default. Closing.