search

photokandyStudios / gbible

Greek Interlinear Bible for iOS (native)
http://www.photokandy.com/apps/gib
41 stars 31 forks source link

UIMenuItem "Define" not working correctly in iOS 6 iPad #46

Closed hightech2013 closed 11 years ago

hightech2013 commented 11 years ago

In the PKBibleViewController.m the following line of code is not working correctly for iOS 6 iPad but it does for iOS 6 iPhone.

ourMenu.menuItems = [NSArray arrayWithObjects: [[UIMenuItem alloc] initWithTitle:@"Define" action:@selector(defineWord:)],

When "Define" is selected in the iOS 6 iPad simulator we get a popover screen, on which on the top word "Dictionary" and button "Done" are partially not seen. However, when using any other then iOS 6 iPad simulator, everything works fine. I thought you may want to upgrade this app to work correctly with iOS 6 iPad screen when "Define" is selected.

In addition I do have one question. What portion of code actually drives the popover page when "Define" under item menus is selected? That is probably what needs to be updated to support latest iOS 6 iPad screen resolution.

Goodluck.

kerrishotts commented 11 years ago

Thanks for the report. The definition view comes straight out of the iOS libraries, but I may have to monkey with the bounding frame a bit.

hightech2013 commented 11 years ago

That is correct. All you have to do is fix the UIReferenceLibraryViewController bounding for an iPad iOS 6 only.

hightech2013 commented 11 years ago

Happy Holidays and best of wishes to you on continue developing your apps. It is challenging task that requires a lot of time. But at the end you never know what could be the outcome. Good luck...

On Dec 4, 2012, at 4:56 AM, Kerri Shotts wrote:

Thanks for the report. The definition view comes straight out of the iOS libraries, but I may have to monkey with the bounding frame a bit.

— Reply to this email directly or view it on GitHub.

kerrishotts commented 11 years ago

Fixed by rendering a popup instead.

kerrishotts commented 11 years ago

Oh, By the way, I'm not sure if I invited you to the beta test or not. If you'd like to beta test (no pressure, though), just send me your email address at kerrishotts@gmail.com, and I'll send you an invite from TestFlight.