phronmophobic / membrane.term

A terminal emulator in pure clojure
Eclipse Public License 1.0
58 stars 1 forks source link

Support color schemes #4

Closed lread closed 3 years ago

lread commented 3 years ago

New :color-scheme option specifies iTerm format color scheme. See changes to README for usage.

In support of this change, scheme-able color support added for:

Also:

Notes:

Closes #1

lread commented 3 years ago

@phronmophobic, my first crack at color schemes, very happy to make changes, lemme know whatcha think.

phronmophobic commented 3 years ago

Added support for 24-bit colors.

What are the changes for 24-bit?

phronmophobic commented 3 years ago

noticed membrane.term was crashing when I tried https://github.com/sharkdp/bat.

I couldn't reproduce a crash. If you have a way to reproduce, can you file an issue?

lread commented 3 years ago

Added support for 24-bit colors.

What are the changes for 24-bit?

I really should have put this in a separate PR instead of sneaking it into this one. Sorry about that! The change was very minor. We just needed to understand that asciinema/vt can also return an [r g b] vector representing a 24-bit color.

lread commented 3 years ago

noticed membrane.term was crashing when I tried https://github.com/sharkdp/bat.

I couldn't reproduce a crash. If you have a way to reproduce, can you file an issue?

Crash might have been strong wording. It just died with a normal JVM exception. I'll file an issue with a repro.

phronmophobic commented 3 years ago

Sounds good. Merged. Thank you!