search

piero-la-lune / FSE-Planner

FSEconomy map vizualisation application
MIT License
41 stars 15 forks source link

Pass actions to Result #134

Closed icykoneko closed 2 years ago

icykoneko commented 2 years ago

Fixes bug where clicking on the airport name in results would cause an exception. See: https://github.com/piero-la-lune/FSE-Planner/blob/3c36b426818dda5defc97074eeb5e1dc56d534e0/src/Routing/Result.js#L231

piero-la-lune commented 2 years ago

Nice catch, thanks for the bug fix

IM0001GT commented 2 years ago

Question, (Not a programmer at all). Did this fix have something to do with the way FSE Planner no longer brings up the airport you click on in the Flight Planner Results?

In the past clicking on the name in the list was the easiest to verify the name needed to use in MSFS. Now you have to go hunting for it a little.

icykoneko commented 2 years ago

Shouldn’t have. If you clicked on the name in there, it would crash. In the past, it would select and zoom to the airport on the map, and that popup would display airport alternatives and such.

On Thu, Apr 21, 2022 at 11:33 PM IM0001GT @.***> wrote:

Question, (Not a programmer at all). Did this fix have something to do with the way FSE Planner no longer brings up the airport you click on in the Flight Planner Results?

In the past clicking on the name in the list was the easiest to verify the name needed to use in MSFS. Now you have to go hunting for it a little.

— Reply to this email directly, view it on GitHub https://github.com/piero-la-lune/FSE-Planner/pull/134#issuecomment-1105968511, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG2BPIWAZIJZLR2PTWOWSC3VGIMWVANCNFSM5TUBWU7A . You are receiving this because you authored the thread.Message ID: @.***>

piero-la-lune commented 2 years ago

Question, (Not a programmer at all). Did this fix have something to do with the way FSE Planner no longer brings up the airport you click on in the Flight Planner Results?

In the past clicking on the name in the list was the easiest to verify the name needed to use in MSFS. Now you have to go hunting for it a little.

It does fix this