piero-la-lune / FSE-Planner

FSEconomy map vizualisation application
MIT License
40 stars 15 forks source link

FSE airports with alternative shown as unavailable #159

Closed ariefwt closed 1 year ago

ariefwt commented 1 year ago

Hello,

I'd like to show you something, which may or may not be a bug

I set the Simulator setting to MSFS, like this: image

And I recently noticed that there are some FSEconomy airports which appear to have at least one MSFS alternative airport around them (visually appears close by and within the FSE airport landing area grid lines) but are marked as unavailable (with double strikethrough) and thus are excluded from the route finder

I have two examples: FSEconomy's SWGR and SB4D

image

image

In both cases, there is at least one MSFS alternative within the FSE airport landing area, but SWGR is marked as unavailable, while SB4D is "renamed" to SSZJ

I expected both airports to be marked as available, SWGR could've been "renamed" to SWDC and be part of the route finder

Here's my debug.json if necessary: debug.json.txt

piero-la-lune commented 1 year ago

This is the intended behavior.

If you zoom in around the SWGR area, you will see that the FSE and MSFS airports are not exactly at the same spot, FSE Planner considers those two locations as different airports. However, you can clearly see that the SB4D (FSE) and SSZJ (MSFS) ICAOs reference the same airstrip.

If the distance is greater than 2km (arbitrary distance I chose), FSE Planner will consider that the MSFS airport is a valid landing area for the given FSE airport, but will consider that this is however a different airport (and therefore make the FSE location appear as closed).

On the contrary, if the distance is less than 2km, FSE Planner will consider that the airport still exists, but has changed its ICAO.

ariefwt commented 1 year ago

Hmmm but this arbitrary 2 km distance unfortunately means airports we can use is hidden from route finder, despite having lots of assignments.

Is it possible to have an alternative mechanism, where as long as there's a simulator-compatible airport within the FSEconomy landing area, it'll be made available in route finder? This way, we can fly to more places we previously thought we can't.

piero-la-lune commented 1 year ago

I have added a new parameter to allow for this:

image

It will be shipped with the next FSE Planner release