pik-piam / edgeTransport

A detailed transport sector model.
5 stars 15 forks source link

Duplicated Variable from toolReportEDGET() #249

Open 0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q opened 4 months ago

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q commented 4 months ago

Passenger and freight transportation are reported both with the same variable name ES|Transport edge|Road.

jmuessel commented 4 months ago

I don't understand, could you clarify this? Road = PassIRoad + FreightIRoad

With PassIRoad

FreightIRoad is not explicitly reported in the code - but it will be in the refactored version.

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q commented 4 months ago
$ sed -n '1 p; /ES|Transport edge|Road/ p' /p/projects/remind/modeltests/remind/output/SSP2EU-NPi-AMT_2024-05-03_22.07.56/REMIND_generic_SSP2EU-NPi-AMT.mif | column -ts ';' | cut -c -80
Model   Scenario        Region  Variable                Unit       2005         
REMIND  SSP2EU-NPi-AMT  CAZ     ES|Transport edge|Road  bn tkm/yr  541.326361608
REMIND  SSP2EU-NPi-AMT  CHA     ES|Transport edge|Road  bn tkm/yr  3055.87690156
REMIND  SSP2EU-NPi-AMT  EUR     ES|Transport edge|Road  bn tkm/yr  2214.39924409
REMIND  SSP2EU-NPi-AMT  IND     ES|Transport edge|Road  bn tkm/yr  326.468748643
REMIND  SSP2EU-NPi-AMT  JPN     ES|Transport edge|Road  bn tkm/yr  118.279397543
REMIND  SSP2EU-NPi-AMT  LAM     ES|Transport edge|Road  bn tkm/yr  1502.78115769
REMIND  SSP2EU-NPi-AMT  MEA     ES|Transport edge|Road  bn tkm/yr  766.860793675
REMIND  SSP2EU-NPi-AMT  NEU     ES|Transport edge|Road  bn tkm/yr  241.951060997
REMIND  SSP2EU-NPi-AMT  OAS     ES|Transport edge|Road  bn tkm/yr  700.527102192
REMIND  SSP2EU-NPi-AMT  REF     ES|Transport edge|Road  bn tkm/yr  427.239215366
REMIND  SSP2EU-NPi-AMT  SSA     ES|Transport edge|Road  bn tkm/yr  293.671687987
REMIND  SSP2EU-NPi-AMT  USA     ES|Transport edge|Road  bn tkm/yr  1987.66287926
REMIND  SSP2EU-NPi-AMT  CAZ     ES|Transport edge|Road  bn pkm/yr  1141.99169417
REMIND  SSP2EU-NPi-AMT  CHA     ES|Transport edge|Road  bn pkm/yr  4047.23400603
REMIND  SSP2EU-NPi-AMT  EUR     ES|Transport edge|Road  bn pkm/yr  6306.93276231
REMIND  SSP2EU-NPi-AMT  IND     ES|Transport edge|Road  bn pkm/yr  1750.62238782
REMIND  SSP2EU-NPi-AMT  JPN     ES|Transport edge|Road  bn pkm/yr  983.300225971
REMIND  SSP2EU-NPi-AMT  LAM     ES|Transport edge|Road  bn pkm/yr  3166.59806364
REMIND  SSP2EU-NPi-AMT  MEA     ES|Transport edge|Road  bn pkm/yr  2919.72919020
REMIND  SSP2EU-NPi-AMT  NEU     ES|Transport edge|Road  bn pkm/yr  444.397416054
REMIND  SSP2EU-NPi-AMT  OAS     ES|Transport edge|Road  bn pkm/yr  3517.41135939
REMIND  SSP2EU-NPi-AMT  REF     ES|Transport edge|Road  bn pkm/yr  1270.24087917
REMIND  SSP2EU-NPi-AMT  SSA     ES|Transport edge|Road  bn pkm/yr  1774.67659123
REMIND  SSP2EU-NPi-AMT  USA     ES|Transport edge|Road  bn pkm/yr  7247.55752516
REMIND  SSP2EU-NPi-AMT  World   ES|Transport edge|Road  bn tkm/yr  12177.0445506
REMIND  SSP2EU-NPi-AMT  World   ES|Transport edge|Road  bn pkm/yr  34570.6921012

There are two ES|Transport edge|Road variables in the .mif files.

jmuessel commented 4 months ago

Thank you for showing the example! I noted it and hope that with our new reporting package, the bug will be solved.

orichters commented 3 months ago

Just noted the difference in units between the two. So I think summing them is just a bit pointless anyway.

You might need to convert persons to tons using average passenger mass :duck:

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q commented 3 months ago

tpe – tonne of person equivalent. But that is a highly regionalised unit, with heavy variations from say USA to Somalia …

orichters commented 2 weeks ago

With EDGE-T 2.0, the fact that the variable is duplicated is now solved, but I do not understand the meaning of the unit billion (p|t)km/yr for ES|Transport and subvariables. Is it just the sum of pkm + tkm, so basically assuming a "tonne of person equivalent", as @0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q called it, set to 1?

LaviniaBaumstark commented 2 days ago

can this issue be closed?