pioneers / runtime

Firmware for the PiE kit robots and devices
7 stars 2 forks source link

[NET_HANDLER] readonly attribute added to Param protos #185

Closed AVSurfer123 closed 3 years ago

AVSurfer123 commented 3 years ago

Adding flag to the Param protobuf whether the param is read only for the student. Also changed how UDP data is tested by directly checking the DevData* struct rather than doing string matching.

Closes #152

benliao1 commented 3 years ago

Looks good, the only thing I'd add is maybe a test to make sure that the info is sent to Dawn?

AVSurfer123 commented 3 years ago

TODO: Need to add assertion functions to test.c that will check the provided DevData* struct for correctness. This is since I removed the printing from the net_handler_client and moved it into the net_handler_cli where it belongs. I currently don't have the time to do this though if someone else wants to finish it.