Sol v0.8 - Githubissues

pipermerriam / ethereum-datetime

Date-Time utilities for ethereum contracts.

MIT License

379 stars 139 forks source link

Sol v0.8 #21

Open RyanRHall opened 2 years ago

RyanRHall commented 2 years ago

This PR does the following:

upgrades the DateTime contract to sol v0.8
introduces brownie as a dependency for running tests locally
adds a CI workflow to hopefully make future changes easier to manage

pipermerriam commented 2 years ago

Should I expect the CI workflow to run in this PR? I did a quick check of permissions and it seems it should be running.

RyanRHall commented 2 years ago

@pipermerriam I'm guessing we're not seeing the CI runs because the PR is cross-repository. Probably some github policy. When I make PRs onto our fork of the repo, CI works fine.

If you want to see the CI run before merging, you'll probably have to pull this branch, push up a local copy, and open a new PR.

RyanRHall commented 2 years ago

According to github, you should be able to "approve and run" @pipermerriam https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks#approving-workflow-runs-on-a-pull-request-from-a-public-fork

lightclient commented 2 years ago

Maybe try to rename ci.yml to ci.yaml?

RyanRHall commented 2 years ago

Maybe try to rename ci.yml to ci.yaml?

CI works fine. It's just disabled for outside contributors.