search

piskvorky / sqlitedict

Persistent dict, backed by sqlite3 and pickle, multithread-safe.
Apache License 2.0
1.17k stars 131 forks source link

Added compatibility for pickle #12

Closed vrescobar closed 10 years ago

vrescobar commented 10 years ago

I saw not every platform has cPickle available so I added this try-except for pickle.

piskvorky commented 10 years ago

Interesting.

Where was the cPickle missing, which platform?

vrescobar commented 10 years ago

Same platform (intel mac) using latest CPython 3.4 (I am porting it in a separate branch); the default python installation from python.org (latest 2.7.x) came with the C implementation, but it’s always recommend to offer the pure python alternative as the documentation suggest (being the C version just an alternative implementation of the same Pickle protocol but not always the latest). However I can’t find now the link with the source (perhaps was a forum).

The stuff is that now it works as well and some platforms don’t need to worry about cross compile the C module. BTW I didn’t test it with jython or other runtimes which has no C backend (and I am blindly trusting the unittests).

On 19 Jul 2014, at 15:21, Radim Řehůřek notifications@github.com wrote:

Interesting.

Where was the cPickle missing, which platform?

— Reply to this email directly or view it on GitHub.

piskvorky commented 10 years ago

I see.

sqlitedict doesn't currently support Python 3, so this issue never came up. A port will be great indeed, thanks! I'd like to keep sqlitedict dependency-free, but maybe it's not a big deal even with python 3 anyway... the code is small.

piskvorky commented 10 years ago

Merged, thanks @vrescobar !

vrescobar commented 10 years ago

Well, I am still working on it, just that I though someone else could already benefit of this commit in Python 2 :) Am 19.07.2014 16:20 schrieb "Radim Řehůřek" notifications@github.com:

I see.

sqlitedict doesn't currently support Python 3, so this issue never came up. A port will be great indeed, thanks!

— Reply to this email directly or view it on GitHub https://github.com/piskvorky/sqlitedict/pull/12#issuecomment-49510733.