search

piskvorky / sqlitedict

Persistent dict, backed by sqlite3 and pickle, multithread-safe.
Apache License 2.0
1.16k stars 130 forks source link

Fix interrupted iteration over a SqliteDict instance #153

Closed Cologler closed 1 year ago

Cologler commented 2 years ago

Fixes #69, with weakref reader queue.

Fix maybe #48?

piskvorky commented 1 year ago

@Cologler is it possible to test this functionality somehow?

Also can you resolve the merge conflict please?

Cologler commented 1 year ago

@piskvorky Not sure how to test...😿

Cologler commented 1 year ago

@piskvorky I added a test for this.

mpenkov commented 1 year ago

OK, this looks good to me. I made some changes to reduce code duplication, and added comments to explain what's going on and why.

@Cologler @piskvorky Could you please eyeball the changes and let me know if you spot anything out of order? The tests pass, so we should be fine.

mpenkov commented 1 year ago

@Cologler Why did you delete the code behind the PR?

Cologler commented 1 year ago

@Cologler Why did you delete the code behind the PR?

Sorry, I mistakenly thought the PR was merged 😭. Do you have a copy of the repo?

I have opened a ticket to request to restore the repo.

mpenkov commented 1 year ago

It's OK, I've got a copy of the code locally.