piskvorky / sqlitedict

Persistent dict, backed by sqlite3 and pickle, multithread-safe.
Apache License 2.0
1.17k stars 131 forks source link

Key pickling 2.0: reverse unused #31

Closed jquast closed 6 years ago

jquast commented 9 years ago

This builds on PR #30, retuning coverage to 100% and removing unused traceback handlers.

piskvorky commented 9 years ago

@jquast I see the exception handling code has been removed in this PR. How vital was the code? Is it needed or not?

I'd obviously prefer to have it removed, it obfuscates the code greatly. But I don't remember how critical it is, so I'm afraid to touch it. Can you comment?

(I'm only talking about the inner/out stacks, not key encoding here)

menshikh-iv commented 7 years ago

Hi @jquast @ziky90, are you planning to continue this work?

menshikh-iv commented 6 years ago

This PR looks abandoned, for this reason, I close it.