piuccio / sublime-esformatter

JavaScript formatter plugin for Sublime Text
MIT License
28 stars 20 forks source link

Add support for .editorconfig #56

Closed Palid closed 8 years ago

Palid commented 8 years ago

Some projects I work with have different styling guides and we all use .editorconfig for that. Esformatter doesn't care for .editorconfig and makes me add yet another dotfile to the repo. Is it possible to make it see .editorconfig style-guide?

piuccio commented 8 years ago

I'm not interested in adding support for that, especially considering that there's a pretty good plugin already available https://github.com/sindresorhus/editorconfig-sublime

Palid commented 8 years ago

@piuccio The problem is that esformatter doesn't care for editorconfig files and forces 2spaces everywhere. Even though eslintrc says four and editorconfig does the same. Do we really need another dotfile in the repository, when there are already two for the same thing?

piuccio commented 8 years ago

.editorconfig and . eslintrc only have a subset of configuration options that are meaningful for esformatter. I don't think it's a good design decision to infer options from some other tools configuration files. I won't do it inside this project, but if you convince esformatter itself to support .editorconfig, then you'll automatically have support for it inside sublime-esformatter.