search

pivoine31 / esp32-weather-epd-pvmod

L.Marzen ESP32 Weather station software with additional features
GNU General Public License v3.0
0 stars 1 forks source link

Changes to air polution request from OWM with OWMs auto time and time zone #4

Closed Asdf1qaz closed 2 months ago

Asdf1qaz commented 2 months ago

Sorry, I'm new to git still. I didn't realize that the changes that I did to my fork AFTER the pull request, would be added to it.

They are the updated dependencies, for the POP fix. And battery cal and voltage changes.

Originally, the code would stay running till the battery voltage reached 3V which would absolutely do a lot of damage to a Li-Po battery. You should NEVER take a Li-Po battery below 3.5V as it will DRASTICALLY reduce its life span https://oscarliang.com/wp-content/uploads/2017/02/Lipo-battery-guide-Voltage-vs-capacity-used-percentage.jpg

pivoine31 commented 2 months ago

Thanks for all that stuff. I'm not a github expert neither, but I will try to integrate as soon as I'll find time for.

pivoine31 commented 2 months ago

Did you report this battery information to L Marzen, since he is the software developper ?

pivoine31 commented 2 months ago

merge aqi auto TZ and battery threshold fixes from Asdf1qaz

pivoine31 commented 2 months ago

I have merged your commits into my main branch. Concerning the battery voltage multiplier, I will move it as a customizable define in config.h for commodity. Thanks for your contribution.

-------- Message d'origine -------- De : Asdf1qaz @.> Date : 30/08/2024 02:33 (GMT+01:00) À : pivoine31/esp32-weather-epd-pvmod @.> Cc : Subscribed @.***> Objet : Re: [pivoine31/esp32-weather-epd-pvmod] Changes to air polution request from OWM with OWMs auto time and time zone (PR #4)

Sorry, I'm new to git still. I didn't realize that the changes that I did to my fork AFTER the pull request, would be added to it.

They are the updated dependencies, for the POP fix. And battery cal and voltage changes.

Originally, the code would stay running till the battery voltage reached 3V which would absolutely do a lot of damage to a Li-Po battery. You should NEVER take a Li-Po battery below 3.5V as it will DRASTICALLY reduce its life span https://oscarliang.com/wp-content/uploads/2017/02/Lipo-battery-guide-Voltage-vs-capacity-used-percentage.jpg

— Reply to this email directly, view it on GitHubhttps://github.com/pivoine31/esp32-weather-epd-pvmod/pull/4#issuecomment-2319551277, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BIGSHB5HEV6H2T5FM23HACLZT64WTAVCNFSM6AAAAABNLN47VSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJZGU2TCMRXG4. You are receiving this because you are subscribed to this thread.Message ID: @.***>