search

pkuliyi2015 / sd-webui-stablesr

StableSR for Stable Diffusion WebUI - Ultra High-quality Image Upscaler
https://iceclear.github.io/projects/stablesr/
Other
1.04k stars 53 forks source link

Could you please explore a ComfyUI version of stablesr? Eager to use stablesr in ComfyUI! #54

Open Jeff-goal opened 1 year ago

Jeff-goal commented 1 year ago

Eager to use stablesr in ComfyUI, which is the best upscale method for realphoto, especially for lowres or blurry pic.

IceClear commented 1 year ago

Hi. Thanks for your interest of our work! We are very busy recently. We may consider this later. Contributions are also really appreciated :)

WSJUSA commented 12 months ago

@IceClear hi Jianyi - did you see this I put together: https://github.com/WSJUSA/Comfyui-StableSR

It has bugs because the way Comfy builds the Unet model is different (beyond my expertise). I received some suggested fixes in this thread: https://github.com/WSJUSA/Comfyui-StableSR/issues/1 which I am going to apply and try out

Basically I have worked out how to access the objects needed to apply the unet highjack. Math and tensor details are well beyond my skill.

Hope this can accelerate a Comyui implementation

IceClear commented 12 months ago

@IceClear hi Jianyi - did you see this I put together: https://github.com/WSJUSA/Comfyui-StableSR

It has bugs because the way Comfy builds the Unet model is different (beyond my expertise). I received some suggested fixes in this thread: WSJUSA/Comfyui-StableSR#1 which I am going to apply and try out

Basically I have worked out how to access the objects needed to apply the unet highjack. Math and tensor details are well beyond my skill.

Hope this can accelerate a Comyui implementation

Thanks for your kind implementation :) I may go through it later when I have time. Thanks a lot. BTW, you may add me to the repo if you do not mind.

alenknight commented 11 months ago

came here to say this too. I absolutely love using this extension in Automatic1111 and often have to throw images into it instead of using comfyui workflows. sure wish I could have this in comfy

IceClear commented 11 months ago

came here to say this too. I absolutely love using this extension in Automatic1111 and often have to throw images into it instead of using comfyui workflows. sure wish I could have this in comfy

Thanks for your interest of StableSR :) May I know if this repo works well or problems still exist?

WSJUSA commented 11 months ago

Hi Jianyi

I haven't had a chance to implement some of the suggestions made in comments on the repo I setup. Structurally it implements ComfyUI the right way, and hooks to the Unet instance. There are differences in how ComfyUI sets up the Unet compared to Auto1111. Its possible some of the comments posted to the repo I setup address them.

Maybe this week I can find some time to test again.

Will

On Sat, Dec 2, 2023, 11:19 PM Jianyi Wang @.***> wrote:

came here to say this too. I absolutely love using this extension in Automatic1111 and often have to throw images into it instead of using comfyui workflows. sure wish I could have this in comfy

Thanks for your interest of StableSR :) May I know if this repo https://github.com/WSJUSA/Comfyui-StableSR works well or problems still exist?

— Reply to this email directly, view it on GitHub https://github.com/pkuliyi2015/sd-webui-stablesr/issues/54#issuecomment-1837359698, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQORMN6DBATBKUPPH5SAVNTYHP4ULAVCNFSM6AAAAAA6IJOW5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZXGM2TSNRZHA . You are receiving this because you commented.Message ID: @.***>

EricRollei commented 9 months ago

Just stopping by to say there's interest in a comfyUI implementation of stablesr

CCpt5 commented 9 months ago

Just stopping by to say there's interest in a comfyUI implementation of stablesr

This newish fork works for ComfyUI: https://github.com/gameltb/comfyui-stablesr

Love StableSR - hope these developers keep working on it.