search

plaid / plaid-openapi

API version 2020-09-14
https://plaid.com/docs
91 stars 39 forks source link

dates, datetimes, tooling #122

Closed Lewiscowles1986 closed 1 year ago

Lewiscowles1986 commented 1 year ago

👋 It looks like your dates and date-time entries are subtly breaking a tool I use json-schema-faker when used with JSONSchemaFaker.option({ useExamplesValue: true, useDefaultValue: true });

This is for two reasons I can tell

  1. datetime being set where something should be date (at least according to openapi 3 spec at swagger.io)
  2. date-time (correct OAS3 👍 ) having a "zulu-character terminated string" format without a . (this could well be a json-schema-faker support problem, as the example given in OpenAPI swagger 3 spec is 2017-07-21T17:32:28Z which does match your format.
Lewiscowles1986 commented 1 year ago

Proposed fix MR for the Z string on date-time, should solve [2] https://github.com/json-schema-faker/json-schema-faker/pull/765

Lewiscowles1986 commented 1 year ago

Also a one-liner to fix this spec to comply with the example-given, and description too. https://github.com/plaid/plaid-openapi/pull/123

phoenixy1 commented 1 year ago

thanks!! Like I mentioned on the PR I've submitted a fix for this internally, it will be released here next month.

Lewiscowles1986 commented 1 year ago

👍