search

planetfederal / registry

pycsw + elasticsearch + opensearch + swagger - Based on HHyperMap
MIT License
11 stars 9 forks source link

Add wms legend support tests #117

Closed theduckylittle closed 7 years ago

theduckylittle commented 7 years ago

Added a test case to ensure coverage of the OGC:WMS type + legend url code.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-2.3%) to 96.896% when pulling 7b891bda988ad34ac9460f23e7e31202485929db on theduckylittle:add-wms-legend-support into ccc3f6c463786998b65fd61118c95dd3f5122b23 on boundlessgeo:master.

ingenieroariel commented 7 years ago

@JorgeMartinezG can you help suggest the changes to make the tests on Python 3.5 and Elastic 5.0 work?

I think it is just related to how many items there are in the db (4 vs 5) in one test and how time is formatted in the new example.

JorgeMartinezG commented 7 years ago

@theduckylittle @ingenieroariel

https://github.com/theduckylittle/registry/blob/ee2121ccebf3b5cf5a93abb047df34f51267c6f3/test_registry.py#L379 The assertion must be changed to 5 because a new layer is added into the tests.

https://github.com/theduckylittle/registry/blob/ee2121ccebf3b5cf5a93abb047df34f51267c6f3/test_registry.py#L689 Is this line necessary? If yes, print in python 3 must be written as a function

theduckylittle commented 7 years ago

@JorgeMartinezG - I'm not sure how the debugging statement I put in there got through, I'm usually not so sloppy, sorry! The counts being off puzzles me too as, locally, I thought I had all the tests running fine!

Both changes have been made and pushed.

JorgeMartinezG commented 7 years ago

@theduckylittle There is a conditionat to skip heatmap tests if elasticsearch version is not 5.1