platformsh-templates / django4

Django 4 template starter for Platform.sh
14 stars 10 forks source link

SO toolkit cannot locate dependency files #24

Open chadwcarlson opened 1 year ago

chadwcarlson commented 1 year ago

Describe the bug

When source operations toolkit is run on Django 4, neither the Pipfile or poetry.lock file can be found.

Include some logs

https://github.com/platformsh-templates/django4/actions/runs/4189911585/jobs/7262777039

Reproducing

https://github.com/platformsh-templates/django4/actions/runs/4189911585/jobs/7262777039

Expected behavior

If anything, we would expect that - since the default app is running pip:

Your environment

See above

Screenshots

No response

Additional context

Temporary pipeline fix implemented in https://github.com/platformsh-templates/django4/pull/23

gilzow commented 1 year ago

For transparency/completeness: The Source Operations Toolkit (SOTK) assumes that a .platform.app.yaml configuration file will be present in the same directory as a package manager file. This was done to ensure it doesn't attempt to update a package file that was committed directly to the project in some sub-sub directory but isn't actually managed by the project.

Since we're using ./.platform/applications.yaml instead of .platform.app.yaml in this template, the SOTK doesn't "see" the package manager files. We might need to rethink the logic in how we discover package management files. See https://github.com/platformsh/source-operations/issues/20